Repository navigation
fix(api): require exact match for CSRF whitelist paths - #42118
Merged
Merged
Conversation
check_csrf_token used pattern.match(), which only anchors at the start of the path. Any route starting with a whitelisted prefix (e.g. all workflows/draft/* variable and node-run endpoints) skipped CSRF validation. Use fullmatch() so only the two intended endpoints (keepalive draft sync, archive file download) are exempt.
Contributor
Pyrefly Type Coverage
|
fatelei
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42117.
check_csrf_token()matchedCSRF_WHITE_LISTwithpattern.match(), which anchors only at the start of the path. That silently exempted every route starting with a whitelisted prefix — e.g. allworkflows/draft/*variable CRUD and iteration/loop node-run endpoints — from CSRF validation. Only the two intended endpoints (keepalive draft autosave, archive file download) should be exempt.One-line change:
match()->fullmatch()inapi/libs/token.py, plus regression tests locking the exact-path exemptions in and the prefix paths out.Screenshots
.../workflows/draft/variableswith no tokens passes the CSRF checkUnauthorizedChecklist
tests/unit_tests/libs/, plus neighboring controller suites) — all green.From Hermes Agent