Skip to content

fix event/stream ping - #3553

Merged
takatost merged 1 commit into
langgenius:mainfrom
liuzhenghua:fix/event-ping
Apr 17, 2024
Merged

fix event/stream ping#3553
takatost merged 1 commit into
langgenius:mainfrom
liuzhenghua:fix/event-ping

Conversation

@liuzhenghua

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
the file api/core/app_runner/generate_task_pipeline.py in tag 0.5.10

            elif isinstance(event, QueuePingEvent):
                yield "event: ping\n\n"

but in the tag 0.6.3 returns 'data: ping'

Type of Change

Please delete options that are not relevant.

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

image

  • TODO

Suggested Checklist:

  • [ X] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐍 python 🐞 bug Something isn't working labels Apr 17, 2024
@liuzhenghua

Copy link
Copy Markdown
Contributor Author

@takatost relate to the pull request: #3546

@crazywoola
crazywoola requested review from Yeuoly and takatost April 17, 2024 07:57

@takatost takatost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2024
@takatost
takatost merged commit e02ee3b into langgenius:main Apr 17, 2024
@liuzhenghua
liuzhenghua deleted the fix/event-ping branch April 18, 2024 11:57
HSPK added a commit to puyuantech/dify-local that referenced this pull request Apr 22, 2024
* feat: increase read timeout of OpenAI Compatible API, Ollama, Nvidia LLM (langgenius#3538)

* feat: agent log (langgenius#3537)

Co-authored-by: jyong <[email protected]>

* fix: typo of PublishConfig (langgenius#3540)

* fix: workflow delete edge (langgenius#3541)

* feat: filter empty content messages in llm node (langgenius#3547)

* fix: json-reader-json-output (langgenius#3552)

* fix: tool node show output text variable type error (langgenius#3556)

* feat: economical index support retrieval testing (langgenius#3563)

* optimize question classifier prompt and support keyword hit test (langgenius#3565)

* fix event/stream ping (langgenius#3553)

* enhance: preload general packages (langgenius#3567)

* added claude 3 opus (langgenius#3545)

* feat: code (langgenius#3557)

* feat: add workflow api in Node.js sdk (langgenius#3584)

* Fix: use debounce for switch (langgenius#3585)

* fix: json in raw text sometimes changed back to key value in HTTP node (langgenius#3586)

* test: add scripts for running tests on api module both locally and CI jobs (langgenius#3497)

* add-open-mixtral-8x22b (langgenius#3591)

* docs: Update README.md (langgenius#3577)

* enhance:speedup xinference embedding & rerank  (langgenius#3587)

* fix(openai_api_compatible): fixing the error when converting chunk to json (langgenius#3570)

* feat: stable diffusion 3 (langgenius#3599)

* Feat/enterprise sso (langgenius#3602)

* Add mixtral 8x22b (langgenius#3606)

* fix: copy invite link has duplicated origin (langgenius#3608)

* seucirty: http smuggling (langgenius#3609)

* chore: apply ruff rules on tests and app.py (langgenius#3605)

* feat: Vision switch functionality is provided on OpenRouter (langgenius#3564)

* get dict key indexing_technique in DocumentAddByFileApi (langgenius#3615)

Co-authored-by: songqijun <[email protected]>

* fix: chat rename (langgenius#3627)

* feat: moonshot fc (langgenius#3629)

* add-llama3-for-nvidia-api-catalog (langgenius#3631)

* content fix to continue (langgenius#3633)

Co-authored-by: xiaohan <[email protected]>

* Fix error in [Update yaml and py file in Tavily Tool] (langgenius#3465)

Co-authored-by: Yeuoly <[email protected]>

* feat: add file log (langgenius#3612)

Co-authored-by: liuzhenghua-jk <[email protected]>

* fix: validate languages (langgenius#3638)

* Fix problem with scroll inside chat window (langgenius#3578)

* fix: in alembic's offline mode (db migrate with --sql option), skip data operations (langgenius#3533)

* fix: workflow_run_id not log_id in workflow api doc (langgenius#3658)

* Optimize README_CN (langgenius#3660)

* fix: delete tool parameters cache when sync draft workflow for run workflow use new parameter change in draft workflow  (langgenius#3637)

* python 3.12 support (langgenius#3652)

* version to 0.6.4 (langgenius#3670)

---------

Co-authored-by: takatost <[email protected]>
Co-authored-by: KVOJJJin <[email protected]>
Co-authored-by: jyong <[email protected]>
Co-authored-by: Bowen Liang <[email protected]>
Co-authored-by: zxhlyh <[email protected]>
Co-authored-by: Yeuoly <[email protected]>
Co-authored-by: Joel <[email protected]>
Co-authored-by: Jyong <[email protected]>
Co-authored-by: liuzhenghua <[email protected]>
Co-authored-by: Siddharth Jain <[email protected]>
Co-authored-by: Joshua <[email protected]>
Co-authored-by: Matheus Mondaini <[email protected]>
Co-authored-by: 呆萌闷油瓶 <[email protected]>
Co-authored-by: aniaan <[email protected]>
Co-authored-by: Garfield Dai <[email protected]>
Co-authored-by: jeessy2 <[email protected]>
Co-authored-by: sqj8899 <[email protected]>
Co-authored-by: songqijun <[email protected]>
Co-authored-by: fuckqqcom <[email protected]>
Co-authored-by: xiaohan <[email protected]>
Co-authored-by: Richards Tu <[email protected]>
Co-authored-by: Yeuoly <[email protected]>
Co-authored-by: liuzhenghua-jk <[email protected]>
Co-authored-by: YidaHu <[email protected]>
Co-authored-by: rmmedia <[email protected]>
Co-authored-by: saga.rey <[email protected]>
Co-authored-by: xin.gao <[email protected]>
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants