refactor: use sessionmaker().begin() in console auth controllers#33966
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Pyrefly DiffNo changes detected. |
Pyrefly DiffNo changes detected. |
|
I think update the mock is kind of meaningless. Migrate to container, then update the sessionmaker makes sense. |
|
resolve conflicts |
Pyrefly DiffNo changes detected. |
@dosu how to fix |
|
The Most likely cause: The storage backend isn't properly initialized for the test environment. To fix, ensure your test environment has the storage properly configured. Check:
Since this is in a container integration test, you may need to ensure the storage service container is running and accessible during the test. To reply, just mention @dosu. How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other |
Pyrefly DiffNo changes detected. |
Important
Fixes #<issue number>.Summary
Summary
Part of #24245
Refactor console auth controllers to use
sessionmaker().begin()instead ofSession()with explicitcommit(), following SQLAlchemy best practices.Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods