fix: remove legacy z-index overrides on model config popup#33769
fix: remove legacy z-index overrides on model config popup#33769lyzno1 merged 1 commit intolanggenius:mainfrom
Conversation
…cking order Remove portalToFollowElemContentClassName z-index values that were overriding the Popover's default z-[1002] via tailwind-merge, causing the model configuration popup to appear behind other UI elements. The most critical case was metadata-filter passing z-[50], which made the popup invisible behind the workflow panel. Fixes langgenius#33745 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
dosubot
bot
added
the
size:XS
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a UI layering issue where the model configuration popup was rendering behind other elements. The problem stemmed from legacy z-index overrides being incorrectly applied after the ModelParameterModal component was migrated to use the new Popover primitive. By removing the redundant "portalToFollowElemContentClassName" prop and its associated z-index values from various call sites and the ModelParameterModal component itself, the popup now correctly utilizes the Popover's default z-index, ensuring proper display order. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a z-index issue with the model configuration popup by removing legacy z-index overrides. The changes involve removing the portalToFollowElemContentClassName prop and its usages across multiple components, which was causing the popup to render behind other UI elements. By removing these overrides, the Popover component's default z-index can take effect, resolving the stacking order problem. The removal of the now-unused prop from the ModelParameterModal component is also a good cleanup. The changes are well-targeted and effectively fix the bug described.
3 participants
Fixes #33745
Summary
portalToFollowElemContentClassNamez-index values that override the Popover component's defaultz-[1002]viatailwind-merge, causing the model configuration popup to render behind other UI elementsmetadata-filter/index.tsxpassingz-[50], which placed the popup far below other overlaysz-[1000]or!z-[1002], which were unnecessary since the new Popover primitive already usesz-[1002]by defaultportalToFollowElemContentClassNameprop fromModelParameterModalRoot cause
When the
ModelParameterModalwas migrated fromPortalToFollowElem(defaultz-[60]) to the newPopoverprimitive (defaultz-[1002]), callers still passed legacy z-index overrides throughportalToFollowElemContentClassName. Sincecn()usestailwind-merge, these values override the Popover's defaultz-[1002], breaking the stacking order. This is consistent with the overlay migration guide which states: "portalToFollowElemContentClassNamewith z-index values should be deleted when the surrounding legacy container is migrated."Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods