Skip to content

fix: loop exit condition accepts variables from nodes inside the loop #24183:#24257

Merged
Nov1c444 merged 2 commits intolanggenius:mainfrom
baonudesifeizhai:fix-loop-exit-condition-24183
Aug 21, 2025
Merged

fix: loop exit condition accepts variables from nodes inside the loop #24183:#24257
Nov1c444 merged 2 commits intolanggenius:mainfrom
baonudesifeizhai:fix-loop-exit-condition-24183

Conversation

@baonudesifeizhai
Copy link
Copy Markdown
Contributor

@baonudesifeizhai baonudesifeizhai commented Aug 20, 2025 •
edited by crazywoola
Loading

  • Modified loop node to check break conditions only at LOOP_END event
  • Changed variable existence check to process available conditions only
  • Ensures Variable Assigner and other internal nodes execute before condition check
  • Fixes Loop exit condition #24183: Loop termination condition now accepts variables from internal nodes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@baonudesifeizhai
fix: loop exit condition accepts variables from nodes inside the loop
3cba6cf 
- Modified loop node to check break conditions only at LOOP_END event
- Changed variable existence check to process available conditions only
- Ensures Variable Assigner and other internal nodes execute before condition check
- Fixes GitHub Issue langgenius#24183: Loop termination condition now accepts variables from internal nodes
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 20, 2025
Nov1c444
Nov1c444 approved these changes Aug 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nov1c444 Nov1c444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2025
@Nov1c444 Nov1c444 merged commit ea066f8 into langgenius:main Aug 21, 2025
7 checks passed
Gnomeek added a commit to Gnomeek/dify that referenced this pull request Aug 22, 2025
@Gnomeek @willzhao12318
[Chore/Refactor] except StopIteration -> next( , None)
1f6374c 
ci

add assertion

docs: format all md files (langgenius#24195)

Signed-off-by: yihong0618 <[email protected]>

hotfix: fix multiple case match syntax (langgenius#24204)

feat: notice of the expire of education verify (langgenius#24210)

Co-authored-by: Copilot <[email protected]>

Feat: Education (langgenius#24208)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

chore: translate i18n files (langgenius#24211)

Co-authored-by: iamjoel <[email protected]>

Httpx example (langgenius#24151)

add tyck tool (currently ignore the error) (langgenius#22592)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Fix the bug of automatically appending basepath to image resource. (langgenius#24201)

fix: keep idempotent when init AnalyticdbVectorBySql (langgenius#24239)

Co-authored-by: xiaozeyu <[email protected]>

fix: dataset doc-form compatible (langgenius#24177)

Co-authored-by: huangzhuo <[email protected]>

feature: add test containers base tests for saved message service (langgenius#24259)

Mcp support resource discovery (langgenius#24223)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix: loop exit condition accepts variables from nodes inside the loop  langgenius#24183: (langgenius#24257)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

feat: show the start time with seconds of the app logs (langgenius#24267)

fix(api):Fix the issue of empty and not empty operations failing in k… (langgenius#24276)

Co-authored-by: liumin <[email protected]>

fix: rollback when AnalyticDB create zhparser failed (langgenius#24260)

Co-authored-by: xiaozeyu <[email protected]>

fix: value_type check failed when updating variables (langgenius#24274)

Co-authored-by: me <[email protected]>

[Test] add unit tests for ProviderConfigEncrypter encrypt/mask/decrypt (langgenius#24280)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

refactor: replace try-except blocks with contextlib.suppress for cleaner exception handling (langgenius#24284)

style: replace `h-[1px]` with `h-px` to unify the writing format of Tailwind CSS (langgenius#24146)

Fix: safe defaults for BaseModel dict fields (langgenius#24098)

Co-authored-by: Yongtao Huang <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

[CHORE]: x: T = None to x: Optional[T] = None (langgenius#24217)

feature: add test containers base tests for tag service (langgenius#24313)

[Test] add unit tests for web_reader_tool.py (langgenius#24309)

Co-authored-by: Yongtao Huang <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Annotations example (langgenius#24304)

an example of sessionmaker (langgenius#24246)

feat: implement TooltipManager for managing tooltip lifecycle (langgenius#24236)

Co-authored-by: crazywoola <[email protected]>

Flask 3.1.2 upgrade fix by Avoids using current_user in background thread  (langgenius#24290)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix: Optimize scrolling experience on plugin page (langgenius#24314) (langgenius#24322)

auto format md files (langgenius#24242)

Feat/chat message image first for agent and advanced_chat APP (langgenius#23796)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Update knowledge_retrieval_node.py (langgenius#24111)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

example of next(, None) (langgenius#24345)

feat: Add default value support for all workflow start node variable types (langgenius#24129)

Co-authored-by: crazywoola <[email protected]>
Co-authored-by: Copilot <[email protected]>

refactor: simplify repository factory with Django-style import_string (langgenius#24354)

Fix missing database commit in provider update handler (langgenius#24357)

Node search supports model and name search (langgenius#24331)

[Chore/Refactor] except StopIteration -> next( , None)
qiaofenlin pushed a commit to qiaofenlin/dify that referenced this pull request Aug 24, 2025
@baonudesifeizhai @autofix-ci @qiaofenlin
fix: loop exit condition accepts variables from nodes inside the loop l…
acf208f 
…anggenius#24183: (langgenius#24257)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
ZeroZ-lab pushed a commit to ZeroZ-lab/dify that referenced this pull request Aug 25, 2025
@baonudesifeizhai @autofix-ci @ZeroZ-lab
fix: loop exit condition accepts variables from nodes inside the loop l…
f4f0adc 
…anggenius#24183: (langgenius#24257)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@laipz8200 laipz8200 mentioned this pull request Aug 26, 2025
Closed
qiqizjl pushed a commit to qiqizjl/dify that referenced this pull request Aug 27, 2025
@baonudesifeizhai @autofix-ci @qiqizjl
fix: loop exit condition accepts variables from nodes inside the loop l…
003c506 
…anggenius#24183: (langgenius#24257)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@dosubot dosubot bot mentioned this pull request Aug 28, 2025
Closed
6 tasks
coolfinish pushed a commit to coolfinish/dify that referenced this pull request Aug 31, 2025
Revert "fix: loop exit condition accepts variables from nodes inside …
59adaa1 
…the loop langgenius#24183: (langgenius#24257)"

This reverts commit ea066f8.
coolfinish added a commit to coolfinish/dify that referenced this pull request Aug 31, 2025
@coolfinish
Revert "fix: loop exit condition accepts variables from nodes inside …
05992e1 
…the loop langgenius#24183: (langgenius#24257)"

This reverts commit ea066f8.
@coolfinish coolfinish mentioned this pull request Aug 31, 2025
Merged
5 tasks
@dosubot dosubot bot mentioned this pull request Sep 1, 2025
Closed
6 tasks
HarryReidx pushed a commit to HarryReidx/dify that referenced this pull request Sep 1, 2025
@baonudesifeizhai @autofix-ci @HarryReidx
fix: loop exit condition accepts variables from nodes inside the loop l…
eb1ae62 
…anggenius#24183: (langgenius#24257)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit ea066f8)
@dosubot dosubot bot mentioned this pull request Sep 4, 2025
Closed
6 tasks
This was referenced Sep 15, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nov1c444 Nov1c444 Nov1c444 approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Loop exit condition

2 participants

@baonudesifeizhai @Nov1c444