Skip to content

[CHORE]: x: T = None to x: Optional[T] = None#24217

Merged
crazywoola merged 4 commits intolanggenius:mainfrom
Gnomeek:main
Aug 21, 2025
Merged

[CHORE]: x: T = None to x: Optional[T] = None#24217
crazywoola merged 4 commits intolanggenius:mainfrom
Gnomeek:main

Conversation

@Gnomeek
Copy link
Copy Markdown
Contributor

@Gnomeek Gnomeek commented Aug 20, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

close #24062

Screenshots

This regex: : ((?!Optional\[)(?!.* \| None)(?!None \| ).)+ = None will find all string that : T = None without Optional[]. Cases like : T | None = None or : None | T = None should be excluded.

image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 20, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 20, 2025
@asukaminato0721
Copy link
Copy Markdown
Contributor

core/extension/extension.py:41: error: Incompatible types in assignment (expression has type "Any | None", variable has type "type")  [assignment]
core/app/task_pipeline/based_generate_task_pipeline.py:55: error: Item "None" of "Any | None" has no attribute "description"  [union-attr]

need some assert is not None

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 20, 2025
@Gnomeek
Copy link
Copy Markdown
Contributor Author

Gnomeek commented Aug 21, 2025

CI job got cancelled somehow

@asukaminato0721
Copy link
Copy Markdown
Contributor

CI job got cancelled somehow

try add some space to trigger the ci :)

@crazywoola crazywoola closed this Aug 21, 2025
@crazywoola crazywoola reopened this Aug 21, 2025
@crazywoola crazywoola merged commit 5ab6bc2 into langgenius:main Aug 21, 2025
14 of 16 checks passed
Eric-Guo pushed a commit to Eric-Guo/dify that referenced this pull request Aug 22, 2025
Eric-Guo pushed a commit to Eric-Guo/dify that referenced this pull request Aug 22, 2025
Gnomeek added a commit to Gnomeek/dify that referenced this pull request Aug 22, 2025
ci

add assertion

docs: format all md files (langgenius#24195)

Signed-off-by: yihong0618 <[email protected]>

hotfix: fix multiple case match syntax (langgenius#24204)

feat: notice of the expire of education verify (langgenius#24210)

Co-authored-by: Copilot <[email protected]>

Feat: Education (langgenius#24208)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

chore: translate i18n files (langgenius#24211)

Co-authored-by: iamjoel <[email protected]>

Httpx example (langgenius#24151)

add tyck tool (currently ignore the error) (langgenius#22592)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Fix the bug of automatically appending basepath to image resource. (langgenius#24201)

fix: keep idempotent when init AnalyticdbVectorBySql (langgenius#24239)

Co-authored-by: xiaozeyu <[email protected]>

fix: dataset doc-form compatible (langgenius#24177)

Co-authored-by: huangzhuo <[email protected]>

feature: add test containers base tests for saved message service (langgenius#24259)

Mcp support resource discovery (langgenius#24223)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix: loop exit condition accepts variables from nodes inside the loop  langgenius#24183: (langgenius#24257)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

feat: show the start time with seconds of the app logs (langgenius#24267)

fix(api):Fix the issue of empty and not empty operations failing in k… (langgenius#24276)

Co-authored-by: liumin <[email protected]>

fix: rollback when AnalyticDB create zhparser failed (langgenius#24260)

Co-authored-by: xiaozeyu <[email protected]>

fix: value_type check failed when updating variables (langgenius#24274)

Co-authored-by: me <[email protected]>

[Test] add unit tests for ProviderConfigEncrypter encrypt/mask/decrypt (langgenius#24280)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

refactor: replace try-except blocks with contextlib.suppress for cleaner exception handling (langgenius#24284)

style: replace `h-[1px]` with `h-px` to unify the writing format of Tailwind CSS (langgenius#24146)

Fix: safe defaults for BaseModel dict fields (langgenius#24098)

Co-authored-by: Yongtao Huang <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

[CHORE]: x: T = None to x: Optional[T] = None (langgenius#24217)

feature: add test containers base tests for tag service (langgenius#24313)

[Test] add unit tests for web_reader_tool.py (langgenius#24309)

Co-authored-by: Yongtao Huang <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Annotations example (langgenius#24304)

an example of sessionmaker (langgenius#24246)

feat: implement TooltipManager for managing tooltip lifecycle (langgenius#24236)

Co-authored-by: crazywoola <[email protected]>

Flask 3.1.2 upgrade fix by Avoids using current_user in background thread  (langgenius#24290)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix: Optimize scrolling experience on plugin page (langgenius#24314) (langgenius#24322)

auto format md files (langgenius#24242)

Feat/chat message image first for agent and advanced_chat APP (langgenius#23796)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Update knowledge_retrieval_node.py (langgenius#24111)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

example of next(, None) (langgenius#24345)

feat: Add default value support for all workflow start node variable types (langgenius#24129)

Co-authored-by: crazywoola <[email protected]>
Co-authored-by: Copilot <[email protected]>

refactor: simplify repository factory with Django-style import_string (langgenius#24354)

Fix missing database commit in provider update handler (langgenius#24357)

Node search supports model and name search (langgenius#24331)

[Chore/Refactor] except StopIteration -> next( , None)
qiaofenlin pushed a commit to qiaofenlin/dify that referenced this pull request Aug 24, 2025
ZeroZ-lab pushed a commit to ZeroZ-lab/dify that referenced this pull request Aug 25, 2025
qiqizjl pushed a commit to qiqizjl/dify that referenced this pull request Aug 27, 2025
HarryReidx pushed a commit to HarryReidx/dify that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore/Refactor] x: T = None to x: Optional[T] = None

3 participants