fix: update first_id logic to use the oldest answer item in chat messages by liugddx · Pull Request #23992 · langgenius/dify

liugddx · 2025-08-15T08:21:23Z

…ages

Important

Make sure you have read our contribution guidelines
Ensure there is an associated issue and you have been assigned to it
Use the correct syntax to link this PR: Fixes #<issue number>.
Close The logs drawer always loading #23971
close fix: add scroll listener for loading conversation history #24003

Summary

Optimized Pagination Logic

Updated first_id parameter to use the oldest answer item instead of the first chat message
Fixed the perpetual loading issue when conversation history exceeds 10 messages

Enhanced Data Handling

Added detection and filtering for duplicate messages
Implemented fallback logic when answer items are not available
Added retry mechanism with alternative ID when initial loading returns duplicates

Improved Error Handling

Added proper error catching and state management
Enhanced logging for better debugging and maintenance

Screenshots

Before	After
...	...

Checklist

This change requires a documentation update, included: Dify Document
I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.
I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

…rror

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

This PR fixes a pagination issue in the chat message loading logic by updating the first_id parameter to use the oldest answer item instead of the first chat message. This resolves perpetual loading when conversation history exceeds 10 messages and implements custom scroll handling to replace the react-infinite-scroll-component library.

Optimized pagination by using the oldest answer item ID for the first_id parameter
Replaced infinite scroll library with custom scroll handling and duplicate message detection
Enhanced error handling and loading state management for better reliability

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

web/app/components/app/log/list.tsx

Co-authored-by: Copilot <[email protected]>

Co-authored-by: crazywoola <[email protected]>

…ages (langgenius#23992) Co-authored-by: Copilot <[email protected]> Co-authored-by: crazywoola <[email protected]>

* Restore useLabelStore mistakenly removed in commit 403e2d5 (langgenius#24052) Co-authored-by: Yongtao Huang <[email protected]> Co-authored-by: crazywoola <[email protected]> * chore: synchronize translations (langgenius#24044) * feat: add testcontainers based tests for metadata service (langgenius#24048) * feat: add testcontainers based tests for model loadbalancing service (langgenius#24066) * feat: add select input support to the conversation opener (langgenius#24043) * feat: add CLAUDE.md for LLM-assisted development guidance (langgenius#23946) * feat: add Redis SSL/TLS certificate authentication support (langgenius#23624) * Fix sticky table header transparency with backdrop-filter blur in dark mode (langgenius#23999) * fix: update first_id logic to use the oldest answer item in chat messages (langgenius#23992) Co-authored-by: Copilot <[email protected]> Co-authored-by: crazywoola <[email protected]> * refactor: improve loading animation and debug panel styles (langgenius#24075) * fix(oauth): redis compatibility (langgenius#23959) * feat: enchance prompt and code (langgenius#23633) Co-authored-by: stream <[email protected]> Co-authored-by: Stream <[email protected]> Co-authored-by: Stream <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: return empty list instead of raising exception for qdrant search when score_threshold is 1 (langgenius#24032) * chore: translate i18n files (langgenius#24081) Co-authored-by: Stream29 <[email protected]> * fix: no current code caused code generation show error (langgenius#24086) * fix(ui): Optimize UI component styles and layouts (langgenius#24090) (langgenius#24092) * feat: no longer enable auto upgrade when marketplace is disabled (langgenius#24… (langgenius#24101) * Feature/improve goto anything commands (langgenius#24091) * chore: translate i18n files (langgenius#24102) Co-authored-by: crazywoola <[email protected]> * fix pg_vector extension requires SUPERUSER, but not available on Huawei Cloud RDS (langgenius#24093) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Revert "fix pg_vector extension requires SUPERUSER, but not availabl… (langgenius#24108) * fix: validate checklist before publishing workflow (langgenius#24104) * Chore: remove some dead code in experience-enhance-group (langgenius#24110) Co-authored-by: Yongtao Huang <[email protected]> * fix: treat default template of code as empty (langgenius#24106) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Bump pyobvector to 0.2.15 (langgenius#24120) * Use typing.Literal to replace str places (langgenius#24099) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * feat: add delete avatar functionality with confirmation modal (langgenius#24127) Co-authored-by: crazywoola <[email protected]> * chore: translate i18n files (langgenius#24131) Co-authored-by: crazywoola <[email protected]> * an example of suppress (langgenius#24136) * feat: add testcontainers based tests for feature service (langgenius#24026) * feat: Implements periodic deletion of workflow run logs that exceed t… (langgenius#23881) Co-authored-by: shiyun.li973792 <[email protected]> Co-authored-by: 1wangshu <[email protected]> Co-authored-by: Blackoutta <[email protected]> Co-authored-by: crazywoola <[email protected]> * try ast-grep (langgenius#24149) * fix: correct behaviour of code fix (langgenius#24152) Co-authored-by: Joel <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Fix number input in tool configure form of agent node tool item (langgenius#24154) * Remove the second `if self.runtime is None:` check (langgenius#24171) Co-authored-by: Yongtao Huang <[email protected]> * Fix: correctly match http/https URLs in image upload file (langgenius#24180) * feat: add testcontainers based tests for model provider service (langgenius#24193) * Fix: replace `get_builtin_provider` with `get_plugin_provider` (langgenius#24191) * docs: format all md files (langgenius#24195) Signed-off-by: yihong0618 <[email protected]> * hotfix: fix multiple case match syntax (langgenius#24204) --------- Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Yongtao Huang <[email protected]> Co-authored-by: Yongtao Huang <[email protected]> Co-authored-by: crazywoola <[email protected]> Co-authored-by: lyzno1 <[email protected]> Co-authored-by: NeatGuyCoding <[email protected]> Co-authored-by: Zhehao Peng <[email protected]> Co-authored-by: -LAN- <[email protected]> Co-authored-by: Guangdong Liu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Wu Tianwei <[email protected]> Co-authored-by: Maries <[email protected]> Co-authored-by: Joel <[email protected]> Co-authored-by: stream <[email protected]> Co-authored-by: Stream <[email protected]> Co-authored-by: Stream <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Bo Wu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stream29 <[email protected]> Co-authored-by: HyaCinth <[email protected]> Co-authored-by: Junyan Qin (Chin) <[email protected]> Co-authored-by: GuanMu <[email protected]> Co-authored-by: Elvis_LEE <[email protected]> Co-authored-by: He Wang <[email protected]> Co-authored-by: crazywoola <[email protected]> Co-authored-by: 9527MrLi <[email protected]> Co-authored-by: shiyun.li973792 <[email protected]> Co-authored-by: 1wangshu <[email protected]> Co-authored-by: Blackoutta <[email protected]> Co-authored-by: KVOJJJin <[email protected]> Co-authored-by: yihong <[email protected]>

…ages (langgenius#23992) Co-authored-by: Copilot <[email protected]> Co-authored-by: crazywoola <[email protected]>

…ages (langgenius#23992) Co-authored-by: Copilot <[email protected]> Co-authored-by: crazywoola <[email protected]> (cherry picked from commit 6b51530)

crazywoola self-assigned this Aug 17, 2025

crazywoola requested review from Copilot and crazywoola August 17, 2025 01:34

This comment was marked as outdated.

Sign in to view

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 17, 2025

fix: improve auto-loading of chat items and handle loading state on e…

1c148f2

…rror

liugddx force-pushed the 23971 branch from e4b564b to 1c148f2 Compare August 17, 2025 14:35

liugddx requested a review from Copilot August 18, 2025 01:26

This comment was marked as outdated.

Sign in to view

liugddx and others added 5 commits August 18, 2025 09:28

Update web/app/components/app/log/list.tsx

63c7782

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

f3869dc

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

d60d452

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

83dd92e

Co-authored-by: Copilot <[email protected]>

fix: 修复ESLint报错，消除未使用变量警告和简化回调函数

acf36bd

crazywoola requested a review from Copilot August 18, 2025 02:47

Copilot AI reviewed Aug 18, 2025

View reviewed changes

crazywoola reviewed Aug 18, 2025

View reviewed changes

web/app/components/app/log/list.tsx Outdated Show resolved Hide resolved

liugddx and others added 5 commits August 18, 2025 10:52

Update web/app/components/app/log/list.tsx

a9dbc26

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

7e93d43

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

8936bd7

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

9c449df

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

69779c8

Co-authored-by: Copilot <[email protected]>

liugddx and others added 4 commits August 18, 2025 10:53

Update web/app/components/app/log/list.tsx

41cf00f

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

6bb7452

Co-authored-by: Copilot <[email protected]>

Update web/app/components/app/log/list.tsx

245a202

Co-authored-by: crazywoola <[email protected]>

fix: 修复代码语法错误和重复条件判断

0bf4ccb

crazywoola approved these changes Aug 18, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 18, 2025

crazywoola merged commit 6b51530 into langgenius:main Aug 18, 2025
6 checks passed

qiqizjl pushed a commit to qiqizjl/dify that referenced this pull request Aug 27, 2025

fix: update first_id logic to use the oldest answer item in chat mess…

29912d9

…ages (langgenius#23992) Co-authored-by: Copilot <[email protected]> Co-authored-by: crazywoola <[email protected]>

dosubot bot mentioned this pull request Aug 28, 2025

UnboundLocalError: cannot access local variable 'current_page_first_message' where it is not associated with a value #24686

Closed

6 tasks

dosubot bot mentioned this pull request Dec 11, 2025

Unable to load more chatflow history messages normally #29488

Closed

6 tasks

dosubot bot mentioned this pull request Mar 6, 2026

The runnning logs only reads the latest 10 entries. #24952

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update first_id logic to use the oldest answer item in chat messages#23992

fix: update first_id logic to use the oldest answer item in chat messages#23992
crazywoola merged 15 commits intolanggenius:mainfrom
liugddx:23971

liugddx commented Aug 15, 2025 •

edited by crazywoola

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

liugddx commented Aug 15, 2025 • edited by crazywoola Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

liugddx commented Aug 15, 2025 •

edited by crazywoola

Loading