-
Notifications
You must be signed in to change notification settings - Fork 21.2k
[Chore/Refactor] use typing.Literal in some str place #24040
Copy link
Copy link
Closed
Labels
good first issueGood first issue for newcomersGood first issue for newcomers
Description
Self Checks
- I have read the Contributing Guide and Language Policy.
- This is only for refactoring, if you would like to ask a question, please head to Discussions.
- I have searched for existing issues search for existing issues, including closed ones.
- I confirm that I am using English to submit this report, otherwise it will be closed.
- 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
- Please do not modify this template :) and fill in all the required fields.
Description
some places like
| def post(self, app_model: App, action): |
dify/api/controllers/service_api/app/annotation.py
Lines 24 to 29 in 32fa817
| if action == "enable": | |
| result = AppAnnotationService.enable_app_annotation(args, app_model.id) | |
| elif action == "disable": | |
| result = AppAnnotationService.disable_app_annotation(app_model.id) | |
| else: | |
| raise ValueError("Unsupported annotation reply action") |
Here, the type of action is Literal["enable", "disable"].
Motivation
better DX.
Additional Context
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood first issue for newcomersGood first issue for newcomers