Repository navigation
fix(sandbox): timeout Lambda MicroVM requests - #15974
Open
abhinavkr26104 wants to merge 2 commits into
Open
abhinavkr26104 wants to merge 2 commits into
abhinavkr26104 wants to merge 2 commits into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impacted packages
Verification
Notes
Closes #15956
Greptile Summary
This PR adds AbortSignal-based time limits to Lambda MicroVM sandbox operations and bridge health probes, with additional regression tests for hung requests.
Confidence Score: 4/5
The PR should not merge until auth-token acquisition is included in the bridge readiness deadline, otherwise session creation can still hang beyond the promised bound.
The health request and body are now abortable, but every probe first awaits an AWS SDK auth-token request without a timeout or outer guard, leaving ensureSession unbounded under a stalled token request.
Files Needing Attention: packages/shared/src/in-app-agent/server/sandbox/providers/lambdaMicrovm.ts
Sequence Diagram
sequenceDiagram participant Session as ensureSession participant Bridge as waitForBridge participant AWS as Auth-token API participant Health as Bridge /health Session->>Bridge: wait for readiness (30s target) Bridge->>AWS: createMicrovmAuthToken Note over Bridge,AWS: No remaining-deadline timeout AWS-->>Bridge: token after unbounded delay Bridge->>Bridge: calculate remainingMs alt Deadline remains Bridge->>Health: fetch with AbortSignal(remainingMs) Health-->>Bridge: health result else Deadline expired Bridge-->>Session: readiness failure after excess wall time endPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix(sandbox): timeout Lambda MicroVM req..." | Re-trigger Greptile