TUI config clean up#968
Merged
Merged
Conversation
While fixing langflow-ai#967, I noticed that the other file selector input in this form did not validate that the directory could be written to. This adds the DocumentsPathValidator to the OpenSearch data directory field to match the the documents path.
Neither the _create_field nor _create_header_text methods were being used, this deletes them.
This * removes unused imports from tui/screens/config.py * removes unused assignment to current_password * changes f-strings to regular strings when they have no interpolations
Collaborator
|
Thanks for the fixes! |
Collaborator
phact
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #967 and fixes up some things I noticed in the code while fixing #892.
Initially, I noticed that there are two input fields that store directories to save data in, but only the documents path was being validated as a path that could be written to. This adds the same validation to the OpenSearch Data path.
I then noticed there were a couple of unused methods, neither
_create_header_textnor_create_fieldwere being used, so I deleted them.Finally, there were some other miscellaneous issues in the file, so I:
current_password