fix: create env var to skip sample data ingestion, fix bugs on onboarding error handling#963
Merged
Merged
Conversation
…ters in that case
… when failing to ingest files
This was
linked to
issues
Feb 13, 2026
edwinjosechittilappilly
approved these changes
Feb 13, 2026
edwinjosechittilappilly
left a comment
Collaborator
There was a problem hiding this comment.
Tested with INGEST_SAMPLE_DATA as False and No files the indexes were created and was able to ingest files from UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the sample dataset selection logic from the frontend onboarding flow and centralizes sample data ingestion control to a backend environment variable. The onboarding UI no longer presents an option to ingest sample data, and the ingestion behavior is now controlled via the
INGEST_SAMPLE_DATAflag in the backend configuration. Additionally, error handling for sample data ingestion failures has been improved to roll back onboarding steps more reliably.Configuration and feature flag changes:
INGEST_SAMPLE_DATAenvironment variable to.env.example,docker-compose.yml, and Helm charts, allowing ingestion of sample data to be toggled at startup via backend configuration. [1] [2] [3] [4] [5]Frontend onboarding flow simplification:
sampleDataset,setSampleDataset, and related handlers) from onboarding components includingAdvancedOnboarding,AnthropicOnboarding,IBMOnboarding,OllamaOnboarding, andOpenAIOnboarding. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]Error handling improvements:
onboarding-card.tsxto handle both task-level and file-level failures, and to trigger rollback mutation instead of manually stepping back. [1] [2] [3]Code cleanup:
onboarding-card.tsx. [1] [2] [3]These changes streamline the onboarding experience and ensure sample data ingestion is managed consistently via backend configuration.