fix: knowledge delete dialog cleanup#925
Merged
Wallgau merged 5 commits intoFeb 24, 2026
Merged
Conversation
The knowledge deletion dialog formatting was hard to read and could extend to show too much content. This tidies it all up, turns the bulleted points into a real list, and truncates long file names. Should fix langflow-ai#871.
Collaborator
Member
Author
Collaborator
|
@philnash, at least from the example listed:
|
Member
Author
|
Ah, I see. I can change those, though I will note that neither of those lines were changed as part of this PR in the first place. |
Collaborator
|
Thank you! I think April had a note to have a lot of the copy in sentence case, so it's just for consistency |
Member
Author
|
Updated! |
Move formatFilesToDelete to lib/format-files-to-delete.tsx for reuse across components. Update single-file delete dialog in knowledge-actions-dropdown to use structured layout with children prop. Co-authored-by: Cursor <[email protected]>
Wallgau
approved these changes
Feb 23, 2026
| onConfirm={handleDelete} | ||
| isLoading={deleteDocumentMutation.isPending} | ||
| /> | ||
| > |
Collaborator
There was a problem hiding this comment.
it wasn't formatted when selected from the dropdown, fixing it here
Collaborator
|
@Analuisa1a the delete from the dropdown action (in the table row) is now same, are we good with this approach? |
Collaborator
|
@Wallgau yes, this looks great!, Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The knowledge deletion dialog formatting was hard to read and could extend to show too much content. This tidies it all up, turns the bulleted points into a real list, and truncates long file names. Should fix #871.
Before:
After: