fix: Add EC curve-based algorithm selection for JWT#850
Merged
Conversation
Updated the SessionManager to select the JWT algorithm based on the specific elliptic curve used in the EC private key, supporting ES256, ES384, and ES512. Raises an error for unsupported curves.
Changed the test-integration workflow to run on ubuntu-latest instead of a self-hosted ARM64 runner. Added a step to install docker-compose to ensure it is available in the CI environment.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the JWT signing configuration to support EC curve-based algorithm selection and modernizes the CI/CD integration test workflow. The changes enhance security by automatically selecting the appropriate JWT algorithm based on the EC private key's curve type, and improve workflow portability by migrating from a self-hosted ARM64 runner to ubuntu-latest.
Changes:
- Enhanced EC JWT signing to automatically select ES256, ES384, or ES512 based on the curve type (SECP256R1, SECP384R1, or SECP521R1)
- Migrated integration test workflow from self-hosted ARM64 runner to ubuntu-latest for improved portability
- Added docker-compose installation step to ensure dependencies are available
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/session_manager.py | Implements curve-based algorithm selection for EC keys with proper error handling for unsupported curves |
| .github/workflows/test-integration.yml | Updates runner to ubuntu-latest and adds docker-compose installation step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changed the test-integration workflow to run on a self-hosted ARM64 runner with specific labels instead of ubuntu-latest. This enables testing in an environment closer to production or with required hardware resources.
zzzming
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an important update to JWT signing algorithm selection and a minor adjustment to the integration test workflow. The main enhancement is improved handling of elliptic curve keys to select the appropriate JWT algorithm based on the specific curve, ensuring better standards compliance and error handling.
JWT Signing Improvements:
_configure_jwt_signingmethod insrc/session_manager.pyto select the JWT algorithm (ES256,ES384, orES512) based on the exact elliptic curve used (SECP256R1, SECP384R1, or SECP521R1), and to raise a clear error for unsupported curves.CI Workflow Maintenance:
.github/workflows/test-integration.ymlto use the newerdocker composecommand instead of the deprecateddocker-compose.