Skip to content

fix: Stale api keys no longer display on the page once revoked#1934

Merged
Vchen7629 merged 3 commits into
release-0.5.1from
stale-api-key-display-fix-release-0.5.1
Jun 22, 2026
Merged

fix: Stale api keys no longer display on the page once revoked#1934
Vchen7629 merged 3 commits into
release-0.5.1from
stale-api-key-display-fix-release-0.5.1

Conversation

@Vchen7629

@Vchen7629 Vchen7629 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #1877 , Updates the opensearch query to only fetch non revoked (revoked = False) api keys so the frontend recieves only non-revoked keys to display.

Demo (Before)

screen-capture.6.webm

Demo (After)

screen-capture.7.webm

Changes

  • updates api_key_service.py list_keys opensearch query to also filter for keys that have revoked set to false
  • Added a unit test to verify that query is sent correctly

@Vchen7629 Vchen7629 changed the base branch from main to release-0.5.1 June 22, 2026 16:13
@github-actions github-actions Bot added the backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) label Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e177838-4855-44f4-9141-1a54d38cb704

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1) 
Validation error: Too big: expected number to be <=900000 at "reviews.tools.github-checks.timeout_ms"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stale-api-key-display-fix-release-0.5.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 22, 2026
lucaseduoli
lucaseduoli previously requested changes Jun 22, 2026
View reviewed changes

@lucaseduoli lucaseduoli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a test to create an API key, check if the service returns it, revoke it and then check again to see if it disappears?

@github-actions github-actions Bot added tests bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 22, 2026
@Vchen7629 Vchen7629 dismissed lucaseduoli’s stale review June 22, 2026 17:13

Added unit test addressing the comment

@Vchen7629 Vchen7629 requested a review from lucaseduoli June 22, 2026 17:13
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 22, 2026
@github-actions github-actions Bot added the lgtm label Jun 22, 2026
@Vchen7629 Vchen7629 merged commit c3694c5 into release-0.5.1 Jun 22, 2026
8 of 11 checks passed
@github-actions github-actions Bot deleted the stale-api-key-display-fix-release-0.5.1 branch June 22, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaseduoli lucaseduoli lucaseduoli approved these changes

Assignees

No one assigned

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. lgtm tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Revoked api keys still display on the frontend

2 participants

@Vchen7629 @lucaseduoli