Skip to content

fix: restore LLM model values in reapply_all_settings fallback (#1587)#1932

Merged
hunterxtang merged 3 commits into
release-0.5.1from
fix/1587-llm-fallback-update-0.5.1
Jun 22, 2026
Merged

fix: restore LLM model values in reapply_all_settings fallback (#1587)#1932
hunterxtang merged 3 commits into
release-0.5.1from
fix/1587-llm-fallback-update-0.5.1

Conversation

@hunterxtang

@hunterxtang hunterxtang commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1587 on release-0.5.1. Reapplies the LLM-provider fallback fix from #1926, adapted to api/settings.py (0.5.1 keeps this logic in the flat settings module rather than the settings/langflow_sync.py package).

@coderabbitai

coderabbitai Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8872ee14-cc36-40b8-b247-688b51f809a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1) 
Validation error: Too big: expected number to be <=900000 at "reviews.tools.github-checks.timeout_ms"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1587-llm-fallback-update-0.5.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) tests bug 🔴 Something isn't working. labels Jun 18, 2026
Wallgau
Wallgau reviewed Jun 19, 2026
View reviewed changes
Comment thread src/api/settings.py Outdated
Comment thread tests/unit/api/test_langflow_sync_bug_1587.py
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 22, 2026
@github-actions github-actions Bot added the lgtm label Jun 22, 2026
@hunterxtang hunterxtang merged commit fba2be0 into release-0.5.1 Jun 22, 2026
9 checks passed
@github-actions github-actions Bot deleted the fix/1587-llm-fallback-update-0.5.1 branch June 22, 2026 21:04
@hunterxtang hunterxtang mentioned this pull request Jul 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wallgau Wallgau Wallgau left review comments
@lucaseduoli lucaseduoli lucaseduoli approved these changes

Assignees

No one assigned

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. lgtm tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hunterxtang @Wallgau @lucaseduoli