fix: restore LLM model values in reapply_all_settings fallback (#1587)#1926
Closed
hunterxtang wants to merge 4 commits into
Closed
fix: restore LLM model values in reapply_all_settings fallback (#1587)#1926hunterxtang wants to merge 4 commits into
hunterxtang wants to merge 4 commits into
Conversation
The fallback branch of _update_langflow_model_values() only refreshed embedding providers, so LLM selections reverted to stale/default models after a flow reset. Add an LLM provider loop mirroring the embedding logic: current provider gets config.agent.llm_model, others get None (first available), all with force_llm_update=True. Guards config.agent.llm_provider against None before .lower().
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1587. Cherry-picked onto a clean same-repo branch off main so CI runs with secrets. Supersedes #1850.