Skip to content

fix: check backend health inside container#1921

Merged
NishadA05 merged 1 commit into
release-0.5.1from
fix-backend-health-container-check-0.5.1
Jun 22, 2026
Merged

fix: check backend health inside container#1921
NishadA05 merged 1 commit into
release-0.5.1from
fix-backend-health-container-check-0.5.1

Conversation

@NishadA05

Copy link
Copy Markdown
Collaborator

Fixes #1880

Summary

Updates make health so the backend check first tries the existing host health endpoint, then falls back to checking the /health endpoint inside the running openrag-backend container using Podman or Docker.

This fixes a false negative where make health reports:

Backend:    Not responding

even though the backend container is healthy and returns:

{"status":"ok"}

Testing

Tested with backend running:

make health

Result:

Backend:    Healthy

Tested with backend stopped:

podman stop openrag-backend
make health

Result:

Backend:    Not responding

Restored backend:

podman start openrag-backend
make health

Result:

Backend:    Healthy

@github-actions github-actions Bot added the bug 🔴 Something isn't working. label Jun 18, 2026
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf2fa233-f60c-4035-9c6b-79c158dad697

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Too big: expected number to be <=900000 at "reviews.tools.github-checks.timeout_ms"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-backend-health-container-check-0.5.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Wallgau Wallgau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce work!

@github-actions github-actions Bot added the lgtm label Jun 22, 2026
@NishadA05 NishadA05 merged commit 79c6594 into release-0.5.1 Jun 22, 2026
13 checks passed
@github-actions github-actions Bot deleted the fix-backend-health-container-check-0.5.1 branch June 22, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔴 Something isn't working. lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants