fix: Podman compatibility by adding environment configurable repository prefix to Docker Compose image references#1919
Conversation
…or private repo compatibility
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning
|
lucaseduoli
left a comment
There was a problem hiding this comment.
I believe doesn't make sense to use an environment variable for this, since there are no langflowai or opensearchproject repos in any other container registry that is not docker.io. I think it's better to just hard code it, but if there is any other reason behind this, please tell me because I might've missed something.
|
Noted, reverted back to the hardcoded docker.io container registry |
Reverted back to the hardcoded docker.io container registry prefix
Summary
Fixes #1206. Podman fails to resolve unqualified image names (no registry prefix) by default, causing
podman pull/podman compose upto fail with:Error: short-name "langflowai/openrag-backend:latest" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"Changes
docker-compose.ymlwith Added environment variable prefix that defaults todocker.io/(5 images total: opensearch, opensearch-dashboards, backend, frontend, langflow) if none providedTesting
podman compose upnow succeeddocker composestill works identically (fully-qualifieddocker.io/...and unqualified...resolve to the same image on Docker Hub)