Skip to content

fix: target agent component when updating chat flow system prompt#1918

Merged
Vchen7629 merged 6 commits into
release-0.5.1from
agent-system-instruction-fix
Jun 19, 2026
Merged

fix: target agent component when updating chat flow system prompt#1918
Vchen7629 merged 6 commits into
release-0.5.1from
agent-system-instruction-fix

Conversation

@Vchen7629

@Vchen7629 Vchen7629 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #1514. update_chat_flow_system_prompt was targeting the LLM provider component (e.g. "Ollama", "WatsonX") instead of the Agent component where the system_prompt field lives. As a result, saving new agent instructions in OpenRAG settings never updates langflow

Changes:

  • Updated update_chat_flow_system_prompt to use AGENT_COMPONENT_DISPLAY_NAME as the target component
  • Added unit tests verifying the value is written to the Agent component in the flow

@Vchen7629 Vchen7629 requested a review from Wallgau June 18, 2026 17:50
@coderabbitai

coderabbitai Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3ba48c36-14fa-40f5-9efa-df41b85493f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1) 
Validation error: Too big: expected number to be <=900000 at "reviews.tools.github-checks.timeout_ms"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent-system-instruction-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) tests bug 🔴 Something isn't working. labels Jun 18, 2026
@Vchen7629

Vchen7629 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

This is a the same changes as PR #1781, just reopened to change the branch from my fork to the main repo to avoid e2e/integration test issues

@Vchen7629 Vchen7629 mentioned this pull request Jun 18, 2026
Closed
Wallgau
Wallgau approved these changes Jun 18, 2026
View reviewed changes

@Wallgau Wallgau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTM, great work!

@github-actions github-actions Bot added the lgtm label Jun 18, 2026
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 18, 2026
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 19, 2026
@Vchen7629 Vchen7629 merged commit 3e35bb8 into release-0.5.1 Jun 19, 2026
7 checks passed
@github-actions github-actions Bot deleted the agent-system-instruction-fix branch June 19, 2026 20:33
@Vchen7629 Vchen7629 mentioned this pull request Jul 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wallgau Wallgau Wallgau approved these changes

Assignees

No one assigned

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. lgtm tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vchen7629 @Wallgau