src/api/connectors.py (2)

699-720: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

max_files skips orphan cleanup without actually limiting this resync.

In this branch, body.max_files is never passed to reconcile_orphans_for_connector_type() or sync_specific_files(). Setting it only disables orphan filtering, but the endpoint still enqueues every indexed ID, including stale ones.

🐛 Proposed fix

-                if body.max_files is None:
-                    orphan_ids = await reconcile_orphans_for_connector_type(
-                        connector_type=connector_type,
-                        user_id=user.user_id,
-                        connector_service=connector_service,
-                        session_manager=session_manager,
-                        jwt_token=jwt_token,
-                        existing_file_ids=existing_file_ids,
-                        id_field=id_field,
-                    )
-                    if orphan_ids:
-                        orphan_id_set = set(orphan_ids)
-                        ids_to_sync = [fid for fid in existing_file_ids if fid not in orphan_id_set]
+                orphan_ids = await reconcile_orphans_for_connector_type(
+                    connector_type=connector_type,
+                    user_id=user.user_id,
+                    connector_service=connector_service,
+                    session_manager=session_manager,
+                    jwt_token=jwt_token,
+                    existing_file_ids=existing_file_ids,
+                    id_field=id_field,
+                )
+                if orphan_ids:
+                    orphan_id_set = set(orphan_ids)
+                    ids_to_sync = [fid for fid in existing_file_ids if fid not in orphan_id_set]

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/api/connectors.py` around lines 699 - 720, The resync currently ignores
body.max_files — pass body.max_files into reconcile_orphans_for_connector_type
so orphan cleanup respects the limit, and ensure ids_to_sync is truncated to
body.max_files (or pass max_files into sync_specific_files) before enqueuing;
update references in this block to use body.max_files when computing ids_to_sync
and when calling reconcile_orphans_for_connector_type or sync_specific_files so
only up to max_files IDs are processed.

---

699-724: 🛠️ Refactor suggestion | 🟠 Major | 🏗️ Heavy lift

Extract orphan sync planning out of the FastAPI handlers.

The new orphan-filter / deleted-only branching is now duplicated across two routes and is already drifting in behavior. Moving this planning into connector_service or a dedicated helper would keep the handlers as HTTP adapters and centralize one sync policy.

As per coding guidelines, src/api/**/*.py: "No business logic in route handlers."

Also applies to: 1188-1204, 1248-1257

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/api/connectors.py` around lines 699 - 724, The orphan-filtering and
deleted-only branching logic (the reconcile_orphans_for_connector_type call and
the ids_to_sync build-up) should be moved out of the FastAPI handler into
connector_service (or a small helper) so the handler is just an HTTP adapter;
add a method like connector_service.plan_ids_to_sync(existing_file_ids,
max_files, connector_type, user_id, session_manager, jwt_token, id_field) that
encapsulates the current logic (call reconcile_orphans_for_connector_type when
max_files is None, compute orphan_id_set and final ids_to_sync, and return the
ids_to_sync or an empty list/None to indicate no files), then replace the
in-handler block that references reconcile_orphans_for_connector_type,
ids_to_sync, and the subsequent if-not-ids_to_sync response with a simple call
to that new method and handle the no-files response; do the same replacement at
the other duplicated locations (the other handler blocks that currently
duplicate this logic).