Skip to content

fix: update OAuth prompt to consent for connector mutation#1657

Merged
ricofurtado merged 1 commit into
mainfrom
google-Drive-Connection-Fails-After-OpenRAG-Restart-Due-to-Missing-Refresh-Token
May 23, 2026
Merged

fix: update OAuth prompt to consent for connector mutation#1657
ricofurtado merged 1 commit into
mainfrom
google-Drive-Connection-Fails-After-OpenRAG-Restart-Due-to-Missing-Refresh-Token

Conversation

@ricofurtado

@ricofurtado ricofurtado commented May 22, 2026

Copy link
Copy Markdown
Collaborator

After OpenRAG restarts, the Google Drive connector loses its usable OAuth state. Because the OAuth flow uses prompt=select_account instead of forcing consent when needed, Google does not return a new refresh_token on reconnect. If OpenRAG did not persist the original refresh token, or overwrites it with an OAuth response that does not include one, the connector can no longer refresh expired access tokens. As a result, Google Drive appears disconnected after the access token expires.

Summary by CodeRabbit

  • Bug Fixes
    • Updated OAuth authorization prompt behavior during user login and connector setup.

Review Change Stack

@github-actions github-actions Bot added the frontend 🟨 Issues related to the UI/UX label May 22, 2026
@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6488598d-c23d-4562-a7e4-d2529920657f

📥 Commits

Reviewing files that changed from the base of the PR and between 3132a1c and 4d02fab.

📒 Files selected for processing (2)
  • frontend/app/api/mutations/useConnectConnectorMutation.ts
  • frontend/contexts/auth-context.tsx

Walkthrough

OAuth authorization URLs are updated to use prompt=consent instead of prompt=select_account in two locations: the connector connection flow and the authentication provider login flow. These changes apply the same OAuth prompt configuration across both OAuth-based connector and general authentication scenarios.

Changes

OAuth Prompt Parameter Configuration

Layer / File(s) Summary
Update OAuth prompt parameter to consent
frontend/app/api/mutations/useConnectConnectorMutation.ts, frontend/contexts/auth-context.tsx
OAuth authorization URLs now request prompt=consent instead of prompt=select_account in connector connection and auth provider login flows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

bug

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating OAuth prompt parameter from select_account to consent for connector mutations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch google-Drive-Connection-Fails-After-OpenRAG-Restart-Due-to-Missing-Refresh-Token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels May 22, 2026
@github-actions github-actions Bot added the lgtm label May 22, 2026
@ricofurtado ricofurtado merged commit 3f31e5b into main May 23, 2026
19 of 20 checks passed
@github-actions github-actions Bot deleted the google-Drive-Connection-Fails-After-OpenRAG-Restart-Due-to-Missing-Refresh-Token branch May 23, 2026 19:42
ricofurtado added a commit that referenced this pull request May 26, 2026
* fix: Ensure SUCCESS status requires fetchable result in DoclingPollingService

* style: ruff autofix (auto)

* fix: Catch specific DoclingServeError when fetching task result after SUCCESS status

* feat: update style for oss of the failed task in the task panel (#1647)

* update style for oss of the failed task in the task panel

* keep logic on click, remove unecessary useeffect

* fix padding

* wip implementing Saas style

* utils to reshape error until backend provide info we need

* utils to reshape error until backend provide info we need

* utils to reshape error until backend provide info we need and fixinf fallbacks of isTotalFailure

* utils to reshape error until backend provide into

* have Saas style for failed and complete labelstatus and width and border

* few style adjustment to follow codebase pattern

* adjust succeed and partially succeed case

* adding comment for TODO implementation or more clarity

* remove carbon icon package and replace carbon icon

* add incident-reporter-icon

---------

Co-authored-by: Olfa Maslah <[email protected]>

* fix: Encode IBM API key as Basic auth header (#1664)

* Encode IBM API key as Basic auth header

Add base64 encoding for the IBM auth path: import base64, construct a Basic auth token from X-Username and X-Api-Key (username:apikey), and store it in user.jwt_token and user.opensearch_credentials. Also set request.state.user before attaching the DB user ID so downstream code can access the created user object.

* style: ruff autofix (auto)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: restart deployment if env changes (#1665)

* restart deployment if env changes

* unit test

* lint

* fix: Ensure Langflow .env variable definitions from LANGFLOW_VARIABLES_TO_GET_FROM_ENVIRONMENT (#1667)

* Ensure we dynamically update the list of Langflow .env environment variables with default values when the comma separated list defined in LANGFLOW_VARIABLES_TO_GET_FROM_ENVIRONMENT changes

* fix tests

* fix additional linting errors

---------

Co-authored-by: rodageve <[email protected]>

* chore: Retire openrag-mcp; switch docs to streamable HTTP (#1668)

* Retire openrag-mcp; switch docs to streamable HTTP

Remove the stdio-based MCP server and all in-repo MCP tooling, and update README to mark the package as retired. Deleted module files include the MCP entrypoint, server, config, registry and individual tools (chat, search, documents, settings). The README was rewritten to announce that openrag-mcp is retired, explain migration to the built-in streamable-HTTP /mcp endpoint, update Cursor/Claude examples to use URL+headers auth, list the new v1 API tools, and note that the last PyPI release is final. This change consolidates MCP functionality into the OpenRAG core and removes the subprocess/stdio implementation and its source code.

* Mark MCP SDK retired and clean package metadata

Update package metadata to reflect retirement and integration into the OpenRAG backend. Bump version to 0.3.0 and replace the project description with a retirement/migration note. Set Development Status to Inactive, remove explicit Python version classifiers, and clear runtime dependencies and the CLI script entrypoint. Also remove the hatch env pip-args setting; build-system and wheel package target remain unchanged.

* chore: update uv.lock files after version bump

* Update uv.lock

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: connector sync and override feature (#1663)

* Add filename-based duplicate handling for connectors

Add end-to-end support for filename-based duplicate handling on connector ingests.

Frontend: send a new replace_duplicates flag with connector sync requests, perform a pre-sync duplicate check, and show a DuplicateHandlingDialog that lets users overwrite or skip duplicates when uploading from provider UI.

Backend: propagate replace_duplicates through connector_router, request models, and connector services into the file processors. ConnectorFileProcessor and LangflowConnectorFileProcessor now check whether a filename already exists in the index and either fail the file task or delete the existing document before ingesting when replace_duplicates is true.

Utilities/tests: clean_connector_filename now preserves original spacing/slashes and only enforces MIME-mapped extensions; get_filename_aliases adds underscore/sanitized variants so lookups match connector-indexed names. Add unit tests covering filename dedupe logic and filename alias behavior.

* Use duplicateNames list and display names

Replace numeric duplicateCount with a duplicateNames string[] across upload and dropdown flows so the UI can show the actual file names that would be overwritten. The duplicate-handling dialog now accepts duplicateNames, derives an effective count, and lists up to 5 duplicate filenames with an "… and N more" indicator; message labels and button text use the effective count. Toast messages and pending state in upload/[provider]/page.tsx and knowledge-dropdown.tsx were updated to pass and consume duplicateNames and to use duplicateNames.length for counts.

* Update page.tsx

* style: ruff autofix (auto)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: update OAuth prompt to consent for connector mutation (#1657)

* fix: implement transient error handling for Docling result fetch

* style: ruff autofix (auto)

* refactor: remove unused import of Optional in docling_polling_service.py

* refactor: change PollOutcome to use StrEnum for better type safety

* refactor: enhance task status endpoints with structured failure metadata

* style: ruff autofix (auto)

* revert "style: ruff autofix (auto)"

This reverts commit bc8be33.

* style: ruff autofix (auto)

* fix: Ensure SUCCESS status requires fetchable result in DoclingPollingService

* style: ruff autofix (auto)

* fix: Catch specific DoclingServeError when fetching task result after SUCCESS status

* fix: implement transient error handling for Docling result fetch

* style: ruff autofix (auto)

* refactor: remove unused import of Optional in docling_polling_service.py

* refactor: change PollOutcome to use StrEnum for better type safety

* refactor: enhance task status endpoints with structured failure metadata

* style: ruff autofix (auto)

* revert "style: ruff autofix (auto)"

This reverts commit bc8be33.

* style: ruff autofix (auto)

* Update tests/unit/test_task_service_get_task_status2.py

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* style: ruff autofix (auto)

* fix: handle timeout during Docling result fetch after SUCCESS status

* fix: update task status checks to use enum values for consistency

* fix: enhance failure metadata for duplicate file errors in ingestion

* style: ruff autofix (auto)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Wallgau <[email protected]>
Co-authored-by: Olfa Maslah <[email protected]>
Co-authored-by: Edwin Jose <[email protected]>
Co-authored-by: ming <[email protected]>
Co-authored-by: rodageve <[email protected]>
Co-authored-by: rodageve <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔴 Something isn't working. frontend 🟨 Issues related to the UI/UX lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants