fix: change factory-reset functions to delete named volume for opensearch-data#1377
Merged
lucaseduoli merged 3 commits intoApr 13, 2026
Merged
Conversation
github-actions
Bot
added
documentation
Contributor
|
Build successful! ✅ |
mpawlow
approved these changes
Apr 10, 2026
mpawlow
left a comment
mpawlow
left a comment
Collaborator
There was a problem hiding this comment.
Code Review 1
- ✅ LGTM / Approved
- Approval based on changes already reviewed, approved & merged into
mainfor the following Pull Request: - ✅ All changes from the source Pull Request are cleanly included in the target Pull Request
- No commits are missing.
- No regressions were introduced by the rebase onto
main. - All pre-existing issues (resolved or unresolved) were carried forward verbatim.
github-actions
Bot
deleted the
fix/opensearch_volume_factory_reset_release
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all configuration, code, and documentation related to persisting OpenSearch data on the host filesystem via the
OPENSEARCH_DATA_PATHenvironment variable. OpenSearch data is now managed solely via a Docker named volume, simplifying setup and maintenance. As a result, related migration logic, configuration fields, and UI elements have been removed or updated, and all data resets now operate on the Docker volume rather than a directory.OpenSearch Data Path Removal and Volume Management:
OPENSEARCH_DATA_PATHenvironment variable from.env.example,frontend/.env.test.example, and all related documentation and configuration code, including its use in the TUI config, migration, and environment manager. ([[1]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cL57-L60),[[2]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-8bf9c7d2ca83ba5411fc0260b75eb16b8c3594aba50c224b853cc3e972f197d9L9),[[3]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-72c3c3901a4d6baea27175427663092cc1878488406243cde36442d0d3265ed3L140),[[4]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-6e41c9c8008a4d431a159062b3a21caf92777fca9736a36db3e84f5bbe894f95L69-L74),[[5]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-55b27dbaf9d01c8ad5c293b8946007b112980c16553e6fb673068fd000ac7c6eL611),[[6]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-55b27dbaf9d01c8ad5c293b8946007b112980c16553e6fb673068fd000ac7c6eL691),[[7]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-5408077f55d63f67ee40e20ce9b6b1a19f84af6dfe1efaab8a8b4a731739bbc7L97),[[8]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-5408077f55d63f67ee40e20ce9b6b1a19f84af6dfe1efaab8a8b4a731739bbc7L215),[[9]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-5408077f55d63f67ee40e20ce9b6b1a19f84af6dfe1efaab8a8b4a731739bbc7L494-L496))clear_opensearch_data.pyscript and theContainerManagerclass. ([[1]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-66b43037b92e4970806ee19b5321c13e55e0089a307a9c0cd8617c517e092fabL15-L37),[[2]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-26f4c29437cf0f797b720758fa7be3ce43e5018327378cf27893afd79f038c9eL1281-R1311),[[3]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L1017-R1012))opensearch-datadirectory in user home or project directories. ([[1]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-55b27dbaf9d01c8ad5c293b8946007b112980c16553e6fb673068fd000ac7c6eL565-R565),[[2]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-55b27dbaf9d01c8ad5c293b8946007b112980c16553e6fb673068fd000ac7c6eL587-R588),[[3]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-55b27dbaf9d01c8ad5c293b8946007b112980c16553e6fb673068fd000ac7c6eL758),[[4]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-55b27dbaf9d01c8ad5c293b8946007b112980c16553e6fb673068fd000ac7c6eL768))UI and TUI Configuration Cleanup:
[[1]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-42468bc83409b4be7c3754d4e742443aae1dead2bebd8f7c11ecda0dc41e17feL204),[[2]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-42468bc83409b4be7c3754d4e742443aae1dead2bebd8f7c11ecda0dc41e17feL292-L310),[[3]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-42468bc83409b4be7c3754d4e742443aae1dead2bebd8f7c11ecda0dc41e17feL478-L479),[[4]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-42468bc83409b4be7c3754d4e742443aae1dead2bebd8f7c11ecda0dc41e17feL625-L680))Makefile and Documentation Updates:
Makefileto remove references to deleting theopensearch-datadirectory and updated reset/clear commands and help text to reference the Docker volume instead. ([[1]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L509),[[2]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L527-L533),[[3]](https://github.com/langflow-ai/openrag/pull/1377/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L1017-R1012))OPENSEARCH_DATA_PATHvariable and clarify that OpenSearch data is now managed via Docker volumes. ([docs/docs/reference/configuration.mdxL140](https://github.com/langflow-ai/openrag/pull/1377/files#diff-72c3c3901a4d6baea27175427663092cc1878488406243cde36442d0d3265ed3L140))These changes simplify OpenSearch management by using Docker volumes exclusively, reducing configuration complexity and potential user confusion.