Skip to content

fix: removed ibm secrets manager, environment variables and tests#1285

Merged
edwinjosechittilappilly merged 1 commit into
mainfrom
fix/remove_ibm_secrets_manager
Mar 26, 2026
Merged

fix: removed ibm secrets manager, environment variables and tests#1285
edwinjosechittilappilly merged 1 commit into
mainfrom
fix/remove_ibm_secrets_manager

Conversation

@lucaseduoli

Copy link
Copy Markdown
Collaborator

This pull request removes all support for IBM Secrets Manager as a source for the application's master encryption secret. The code now exclusively retrieves the master secret from the OPENRAG_ENCRYPTION_KEY environment variable. All related IBM SDK dependencies and tests have been removed.

Key changes:

Dependency cleanup:

  • Removed ibm-secrets-manager-sdk from the pyproject.toml dependencies, as it is no longer needed.

Encryption secret retrieval changes:

  • Simplified the get_master_secret function in src/utils/encryption.py to only retrieve the secret from the OPENRAG_ENCRYPTION_KEY environment variable, eliminating all logic and error handling related to IBM Secrets Manager.

Test cleanup:

  • Deleted the entire tests/unit/test_ibm_encryption.py file, removing all tests that covered IBM Secrets Manager integration and related fallback logic.

@lucaseduoli lucaseduoli self-assigned this Mar 26, 2026
@github-actions github-actions Bot added backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) tests bug 🔴 Something isn't working. labels Mar 26, 2026

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the lgtm label Mar 26, 2026
@edwinjosechittilappilly edwinjosechittilappilly merged commit ba9356c into main Mar 26, 2026
12 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix/remove_ibm_secrets_manager branch March 26, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. lgtm tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants