fix: removed ibm secrets manager, environment variables and tests#1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all support for IBM Secrets Manager as a source for the application's master encryption secret. The code now exclusively retrieves the master secret from the
OPENRAG_ENCRYPTION_KEYenvironment variable. All related IBM SDK dependencies and tests have been removed.Key changes:
Dependency cleanup:
ibm-secrets-manager-sdkfrom thepyproject.tomldependencies, as it is no longer needed.Encryption secret retrieval changes:
get_master_secretfunction insrc/utils/encryption.pyto only retrieve the secret from theOPENRAG_ENCRYPTION_KEYenvironment variable, eliminating all logic and error handling related to IBM Secrets Manager.Test cleanup:
tests/unit/test_ibm_encryption.pyfile, removing all tests that covered IBM Secrets Manager integration and related fallback logic.