Skip to content

fix: Add validation for chunk size and overlap in settings#1218

Merged
ricofurtado merged 2 commits into
release-0.4.0from
1136-chunk-overlap-vs-chunk-size-validation-qa
Mar 23, 2026
Merged

fix: Add validation for chunk size and overlap in settings#1218
ricofurtado merged 2 commits into
release-0.4.0from
1136-chunk-overlap-vs-chunk-size-validation-qa

Conversation

@ricofurtado

@ricofurtado ricofurtado commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds frontend validation to prevent saving a chunk overlap value greater than or equal to chunk size
  • Shows an inline error message in both the settings page and the cloud-picker ingest settings dialog
  • Blocks the save/ingest action until the values are corrected
  • Adds backend Pydantic validation to reject invalid chunk configurations at the API level

Test plan

  • In Settings page, set Chunk Overlap >= Chunk Size and verify inline error appears and save is blocked
  • Fix the values and verify the error clears and save proceeds
  • In the upload/ingest dialog, set invalid chunk values and verify error appears before ingestion starts
  • Verify valid configurations save and ingest correctly

ricofurtado and others added 2 commits March 23, 2026 08:07
Require Save ingest settings for chunk size, overlap, and docling toggles;
validate on save with inline error, toast, and embedding still immediate.
Fix ModelSelector clearing the value while the model list is still empty.
Validate cloud-picker chunk settings at ingest start via shared helper.

Made-with: Cursor
@github-actions github-actions Bot added frontend 🟨 Issues related to the UI/UX backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Mar 23, 2026
@ricofurtado ricofurtado requested a review from Wallgau March 23, 2026 12:22

@Wallgau Wallgau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the lgtm label Mar 23, 2026
@ricofurtado ricofurtado merged commit 7cab07f into release-0.4.0 Mar 23, 2026
12 checks passed
@github-actions github-actions Bot deleted the 1136-chunk-overlap-vs-chunk-size-validation-qa branch March 23, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. frontend 🟨 Issues related to the UI/UX lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants