Skip to content

fix: update generate nightly tag to use the version of the nightly branch#1200

Merged
lucaseduoli merged 2 commits into
mainfrom
update-to-generate-nightly-tag-from-branch
Mar 19, 2026
Merged

fix: update generate nightly tag to use the version of the nightly branch#1200
lucaseduoli merged 2 commits into
mainfrom
update-to-generate-nightly-tag-from-branch

Conversation

@lucaseduoli

Copy link
Copy Markdown
Collaborator

This pull request updates the nightly build process to allow overriding the base version used for nightly tags via a NIGHTLY_BRANCH environment variable. This enables more flexible nightly build versioning, especially when building from release branches. The main changes are grouped below:

Nightly build workflow enhancements:

  • The GitHub Actions workflow in .github/workflows/nightly-build.yml now sets the NIGHTLY_BRANCH environment variable using a secret, making it available during the nightly tag generation step.

Nightly tag generation script improvements:

  • The scripts/ci/pypi_nightly_tag.py script now imports os and re to support environment variable handling and regex parsing.
  • The nightly tag generation logic in pypi_nightly_tag.py checks for a NIGHTLY_BRANCH environment variable. If set and matching a release branch pattern (e.g., release-0.4.0), it extracts the version from the branch name and uses it as the base version for the nightly tag. Otherwise, it falls back to the local version's base version.

@lucaseduoli lucaseduoli self-assigned this Mar 19, 2026
@github-actions github-actions Bot added ci ⬛ CI/CD, build, and infrastructure issues bug 🔴 Something isn't working. backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) docker and removed bug 🔴 Something isn't working. labels Mar 19, 2026
@lucaseduoli lucaseduoli force-pushed the update-to-generate-nightly-tag-from-branch branch from 89e81cc to 6e4ce2c Compare March 19, 2026 19:52
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Mar 19, 2026

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the lgtm label Mar 19, 2026
@lucaseduoli lucaseduoli merged commit 9d80c2b into main Mar 19, 2026
9 checks passed
@github-actions github-actions Bot deleted the update-to-generate-nightly-tag-from-branch branch March 19, 2026 19:55
lucaseduoli added a commit that referenced this pull request Mar 19, 2026
…anch (#1200)

* update generate nightly tag to use the version of the nightly branch

* Added opensearch build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. ci ⬛ CI/CD, build, and infrastructure issues docker lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants