fix: update generate nightly tag to use the version of the nightly branch#1200
Merged
Merged
Conversation
89e81cc to
6e4ce2c
Compare
lucaseduoli
added a commit
that referenced
this pull request
Mar 19, 2026
…anch (#1200) * update generate nightly tag to use the version of the nightly branch * Added opensearch build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the nightly build process to allow overriding the base version used for nightly tags via a
NIGHTLY_BRANCHenvironment variable. This enables more flexible nightly build versioning, especially when building from release branches. The main changes are grouped below:Nightly build workflow enhancements:
.github/workflows/nightly-build.ymlnow sets theNIGHTLY_BRANCHenvironment variable using a secret, making it available during the nightly tag generation step.Nightly tag generation script improvements:
scripts/ci/pypi_nightly_tag.pyscript now importsosandreto support environment variable handling and regex parsing.pypi_nightly_tag.pychecks for aNIGHTLY_BRANCHenvironment variable. If set and matching a release branch pattern (e.g.,release-0.4.0), it extracts the version from the branch name and uses it as the base version for the nightly tag. Otherwise, it falls back to the local version's base version.