fix: enable sorting across knowledge table columns#1198
Merged
Conversation
Make sortable columns explicit and add typed value getters/comparators so owner, status, and numeric fields sort predictably while preserving default AG Grid sort-cycle behavior. Made-with: Cursor
github-actions
Bot
added
frontend
github-actions
Bot
added
bug
github-actions
Bot
added
bug
lucaseduoli
requested changes
Mar 20, 2026
lucaseduoli
left a comment
lucaseduoli
left a comment
Collaborator
There was a problem hiding this comment.
Seems like sorting by name is not working perfectly with the ingested documentation
Collaborator
Author
Good catch, it seems to be related to url source name, let me fix that. |
Apply a deterministic comparator for the knowledge table Source column by normalizing URL-like values before comparison so title-style source names and URL-derived names sort consistently. Made-with: Cursor
github-actions
Bot
added
bug
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #1172 --> extend request to all sortable column
Screen.Recording.2026-03-19.at.7.34.40.AM.mov