fix: Performance: Adding, removing, updating model providers and changing language or embedding models is slow after upgrade to Langflow 1.8.0 #1193
Merged
Conversation
Keep settings persistence responsive by saving config and returning immediately, while running heavy Langflow global-variable/model propagation asynchronously with safe error logging. Made-with: Cursor
github-actions
Bot
added
backend
github-actions
Bot
added
bug
github-actions
Bot
added
bug
github-actions
Bot
added
bug
Keep a strong reference to the background settings sync task and trigger MCP credential updates when provider removals cause embedding fallback changes. Made-with: Cursor
github-actions
Bot
added
tests
bug
mpawlow
reviewed
Mar 20, 2026
mpawlow
left a comment
mpawlow
left a comment
Collaborator
There was a problem hiding this comment.
Code Review 1
- See PR comments (a), (b)
mpawlow
reviewed
Mar 20, 2026
mpawlow
left a comment
mpawlow
left a comment
Collaborator
There was a problem hiding this comment.
Code Review 2
- ✅ LGTM / Approved
- Doing a final Functional Review
mpawlow
approved these changes
Mar 20, 2026
mpawlow
left a comment
mpawlow
left a comment
Collaborator
There was a problem hiding this comment.
Functional Review 1
- ✅ Approved / LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #1091
Keep settings persistence responsive by saving config and returning immediately, while running heavy Langflow global-variable/model propagation asynchronously with safe error logging.
Screen.Recording.2026-03-18.at.9.17.26.PM.mov