feat: Pdf doc build fix#1104
Merged
Merged
Conversation
Switch default OpenRAG docs onboarding ingestion to URL crawling and align frontend/backend filters to target system_default content. Add guardrails for missing URL flow configuration and missing JWT to prevent onboarding failures and ensure graceful fallback behavior. Made-with: Cursor
Track the OpenRAG version used for default docs ingestion and reingest system docs on application upgrade. Add safe cleanup and startup handling so upgrades refresh docs without failing when optional session context is unavailable. Made-with: Cursor
…tartup reingestion. Centralize URL-ingest eligibility checks, persist remote signature consistently across onboarding and upgrades, add a manual refresh endpoint/UI action, and include targeted signature fallback tests. Made-with: Cursor
Emit start/skip/complete/fail refresh events with non-PII metadata and persist remote signature consistently after refresh to avoid stale state. Made-with: Cursor
Made-with: Cursor
Normalize frontend filter payloads to omit wildcard dimensions and stabilize remote docs signatures by preferring ETag over Last-Modified fallback formatting. Made-with: Cursor
Delete both URL-ingested system_default docs and legacy local sample-data docs during refresh/upgrade to avoid stale default content. Made-with: Cursor
Replace component-id tweaks with X-Langflow-Global-Var passthrough for docs URL and crawl settings so the flow remains stable when component IDs change. Made-with: Cursor
Move URL ingestion request construction/execution into LangflowFileService so main startup code stays orchestration-focused and reuses consistent Langflow header/error handling. Made-with: Cursor
This updates OpenSearch/Langflow fallback retrieval to handle mapping edge-cases and score thresholds consistently, and hardens document deletion UX/API behavior to avoid false-success signals. Made-with: Cursor
Revert frontend, flow-component, and unrelated backend adjustments so this branch focuses on the URL-first default docs ingestion and refresh metadata path. Made-with: Cursor
This reverts commit d775a45.
This ensures empty-query fallback returns no results and that RequestError after num_candidates retry degrades to keyword fallback instead of hard-failing. Made-with: Cursor
Handle 404 responses from document delete as a non-throwing zero-deletion result and update the integration test to account for ingestion runs that complete without indexed chunks. Made-with: Cursor
Restore legacy vector fallback for KNN field errors in Langflow component code and make backend search gracefully degrade to legacy or keyword fallback paths instead of surfacing HTTP 500s when dynamic KNN fields are not queryable. Made-with: Cursor
Keep semantic fallback constrained to documents that contain the legacy embedding field so KNN fallback does not return non-embedded documents, and sync the updated component code into all Langflow flow JSONs. Made-with: Cursor
Made-with: Cursor # Conflicts: # flows/ingestion_flow.json # flows/openrag_agent.json # flows/openrag_nudges.json # flows/openrag_url_mcp.json # src/main.py # src/services/search_service.py
Ensure fallback warning logs in the multimodal OpenSearch component always include reason/error text directly in the message string so the context is reliably emitted across logger implementations. Made-with: Cursor
This reverts commit 81118b2.
Restore the retrieval flow Agent node to the expected model-based template so non-streaming chat calls no longer fail at runtime, and harden OpenSearch legacy fallback filtering in search service. Made-with: Cursor
Handle backend 404 responses as non-fatal in the Python documents client and align integration assertions with environments where ingestion may complete with zero successful files. Made-with: Cursor
Collaborator
Collaborator
Collaborator
UI / UX Review 1
(ux 1a) [Question]: Just to confirm that the UI / UX changes were reviewed / approved by @Analuisa1a(ux 1b) [Minor]: The "Fetch latest docs" button seems to prominent in the "Product Knowledge" page
|
Retry URL ingest flow validation/import once on transient Langflow errors so short outages do not leave URL ingestion broken for the process lifetime. Made-with: Cursor
Add defensive shape checks for legacy vector fallback query rewriting and gracefully fall back to keyword retrieval when expected bool/dis_max paths are missing. Made-with: Cursor
Collaborator
|
Reviewed with @Wallgau Design recommendation is that the icon should stay with sync, but be removed from the fetch, as we don't want to confuse users with the same item. Also, that the buttons should flip as the syncing has priority over the fetching element to the user @mpawlow I would replace fetch with the menu button if we had more items to list. I don't want to hide the button and give the user more clicks if there is only one item hidden. For now, we can show both, but have the Sync take more prominence.
|
Move the Fetch latest docs action after Sync and keep its loading state aligned with the existing row-level refresh cue behavior. Made-with: Cursor
Return a generic message for non-auth delete failures while preserving detailed server-side logging to avoid leaking internal exception details. Made-with: Cursor
Collaborator
|
Sounds good. Thanks @Analuisa1a 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




issue: #575
notes: https://ibm.ent.box.com/notes/2155130295925?s=u5jc90l84zbtouxfsk23bgq4cex168ue
Screen.Recording.2026-03-12.at.7.53.56.AM.mov