fix: make openai not be required for ingestion to work#1101
Merged
Conversation
Collaborator
|
Lucas am updatingt he branch and building local images to test! |
Collaborator
|
Default ingestion works with OpenAI. But switching to WatsonX the ingestion failed. |
Collaborator
|
Premep Approve Change the Var to WATSONX_APIKEY |
edwinjosechittilappilly
approved these changes
Mar 12, 2026
edwinjosechittilappilly
left a comment
Collaborator
There was a problem hiding this comment.
Code LGTM. with NIT variable update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to provider and model configuration logic in flow files and the
flows_service.pybackend. The main focus is on making provider-specific fields more dynamic, updating how embedding nodes are handled, and ensuring models are enabled in Langflow before updating components. Additionally, several flow JSON files are updated to remove hardcoded default values and disable loading from the database for certain fields.Provider/model configuration improvements:
src/services/flows_service.pyfor finding nodes by display name, determining node provider, and mapping provider names for display, which help streamline provider-specific logic._update_provider_componentsto handle multiple embedding nodes, dynamically select which nodes to update based on the number of configured providers, and update existing nodes for the specified provider first._update_component_fieldsto dynamically update provider-specific fields, ensure models are enabled in Langflow before updating, and use a mapping for field values instead of hardcoded logic.Flow JSON file changes:
"WATSONX_PROJECT_ID","OPENAI_API_KEY") and set them to empty strings inflows/ingestion_flow.json,flows/openrag_agent.json,flows/openrag_nudges.json, andflows/openrag_url_mcp.json. [1] [2] [3] [4] [5]project_idandapi_keyin the same flow JSON files. [1] [2] [3] [4] [5]These changes make the provider/model configuration more robust, reduce reliance on hardcoded values, and improve maintainability for future provider additions.