feat: Settings UX should let you remove a model provider by mpawlow · Pull Request #1062 · langflow-ai/openrag

mpawlow · 2026-03-03T21:15:27Z

Issues

[Feat]: Settings UX should let you remove a model provider #833

Summary

Adds the ability for users to remove a configured model provider (OpenAI, Anthropic, IBM watsonx.ai, Ollama) from the Settings UI, with backend validation and automatic fallback to another configured provider.
Polished settings dialogs: form reset on open, autocomplete suppression, and label cleanup
Extracted duplicated dialog footer logic into a shared ModelProviderDialogFooter component across all four provider settings dialogs.

Frontend – Settings Dialogs

Added a "Remove" button to the Ollama, OpenAI, Anthropic, and watsonx settings dialogs, each gated by a tooltip explaining when removal is disabled
Added an inline confirmation footer (with animated slide-in) that appears before executing a destructive remove action, replacing the dialog close behavior
Disabled the remove action when no other provider is configured (prevents being locked out), with a tooltip explaining the reason
Displayed an inline error message from the mutation if the remove request fails

Frontend – Mutation Layer

Extended useUpdateSettingsMutation to support the new remove_*_config boolean fields (remove_ollama_config, remove_openai_config, remove_anthropic_config, remove_watsonx_config)

Backend – Settings API

Added remove_ollama_config, remove_openai_config, remove_anthropic_config, remove_watsonx_config optional boolean fields to SettingsUpdateBody
Implemented removal logic for each provider: clears credentials/endpoint, marks configured = False, and rejects the request with a 400 if no other provider is available
Added _first_configured_llm_provider and _first_configured_embedding_provider helpers to auto-select a fallback provider/model when the active LLM or embedding provider is removed
Ensured Langflow global variables and model values are refreshed after a provider removal (same as a provider update)

Form State & UX Fixes

Added useEffect to reset form state whenever a settings dialog is opened, preventing stale values from persisting across dialog sessions (Anthropic, OpenAI, Ollama, WatsonX)

Password Field Improvements

Added autoComplete="new-password" to API key inputs in Anthropic, OpenAI, and WatsonX settings forms to suppress unwanted browser autofill suggestions

Button Label Cleanup

Shortened the remove confirmation button label from "Confirm Remove" to "Remove" across all four provider dialogs (Anthropic, OpenAI, Ollama, WatsonX)

Refactor: Shared Dialog Footer Component

Created model-provider-dialog-footer.tsx — a new reusable ModelProviderDialogFooter component that encapsulates both the remove-confirmation footer state and the standard save/cancel footer with optional
"Remove" button
Defined a typed ModelProviderDialogFooterProps interface covering all props needed to drive both footer states (pending flags, configured/canRemove guards, tooltip text, and all action callbacks)

Refactored: Provider Settings Dialogs

Replaced the duplicated inline DialogFooter JSX (including Tooltip/TooltipProvider wrappers) in anthropic-settings-dialog.tsx, ollama-settings-dialog.tsx, openai-settings-dialog.tsx, and
watsonx-settings-dialog.tsx with a single usage each
Removed per-dialog imports of DialogFooter, Tooltip, TooltipContent, TooltipProvider, and TooltipTrigger that were no longer needed after extraction

Screenshots

Screencaps

OpenRAG.and.3.more.pages.-.Work.-.Microsoft.Edge.2026-03-06.15-41-07.mp4

mpawlow · 2026-03-06T20:59:27Z

-            </DialogFooter>
+
+            {showRemoveConfirm ? (
+              <DialogFooter className="mt-4 flex items-center gap-2 rounded-lg border border-red-500/10 bg-red-500/5 px-4 py-3 animate-in fade-in-0 slide-in-from-bottom-2 duration-150">


(a) Implementation Note: Used standard animation found elsewhere in the OpenRAG application

Question for Reviewer: Does the selected animation effect & properties align with expectations?

mfortman11

Small issue after removing the connector the api key is "remembered" i the api key field

One other small thing "confirm remove" sound right? vs just "remove" or "confirm removal"?

mpawlow · 2026-03-06T23:07:11Z

@mfortman11

Small issue after removing the connector the api key is "remembered" i the api key field

This is great feedback
I observed this too; but, I figured that was by design
- e.g. Assumption: If the value was defined in .env, then that value is "remembered" / preloaded in the relevant field
- I will verify whether this is true

One other small thing "confirm remove" sound right? vs just "remove" or "confirm removal"?

My preference is for your suggested Confirm Removal text; however, I'll defer to others in terms of what is best in terms of pre-established design patterns / best practices

@aimurphy

Question: Do you have a preference in this matter?

mpawlow · 2026-03-07T00:14:11Z

@mfortman11

Small issue after removing the connector the api key is "remembered" i the api key field

I observed this too; but, I figured that was by design
e.g. Assumption: If the value was defined in .env, then that value is "remembered" / preloaded in the relevant field

Based on my research, it looks like this is indeed by design rather than a bug
The architecture has a two-layer config system
- Layer 1: .env: Infrastructure/secrets (env vars like OLLAMA_ENDPOINT).
  - These represent operator-level configuration of what services are available.
- Layer 2: YAML (via ConfigManager): Runtime settings (what's actively configured and in use)
When a model provider is removed via the UI, the YAML layer is updated (endpoint = "", configured = false).
- But every time the config is loaded, ConfigManager applies env vars on top of the YAML
e.g. Ollama Base URL

  if os.getenv("OLLAMA_ENDPOINT"):
      config_data["providers"]["ollama"]["endpoint"] = os.getenv("OLLAMA_ENDPOINT")

As a result, the endpoint from .env is always re-injected on load, even after removal.
The frontend then sees isOllamaConfigured = false (so the provider isn't active), but the endpoint value is still present, which is why it pre-populates the "Configure" form.
Arguably, this is the desired UX (for user convenience)
- i.e. User can easily add back a removed model provider without having to re-type everything
- Since, configured = false, the provider is inactive (no models served from it, not used for chat/embedding)

aimurphy · 2026-03-09T14:54:57Z

I think the usual pattern is just "Remove".

Like "Are you sure you want to delete?" and the choices are "Cancel" or "Delete".

mpawlow · 2026-03-10T02:04:46Z

Status Update

✅ Polished settings dialogs: form reset on open, autocomplete suppression, and label cleanup
- See: 2aeb6f6

@mfortman11

Ready for Code Review 2 👍

Issues: - #833 Summary Adds the ability for users to remove a configured model provider (OpenAI, Anthropic, IBM watsonx.ai, Ollama) from the Settings UI, with backend validation and automatic fallback to another configured provider. Frontend – Settings Dialogs - Added a "Remove" button to the Ollama, OpenAI, Anthropic, and watsonx settings dialogs, each gated by a tooltip explaining when removal is disabled - Added an inline confirmation footer (with animated slide-in) that appears before executing a destructive remove action, replacing the dialog close behavior - Disabled the remove action when no other provider is configured (prevents being locked out), with a tooltip explaining the reason - Displayed an inline error message from the mutation if the remove request fails Frontend – Mutation Layer - Extended useUpdateSettingsMutation to support the new remove_*_config boolean fields (remove_ollama_config, remove_openai_config, remove_anthropic_config, remove_watsonx_config) Backend – Settings API - Added remove_ollama_config, remove_openai_config, remove_anthropic_config, remove_watsonx_config optional boolean fields to SettingsUpdateBody - Implemented removal logic for each provider: clears credentials/endpoint, marks configured = False, and rejects the request with a 400 if no other provider is available - Added _first_configured_llm_provider and _first_configured_embedding_provider helpers to auto-select a fallback provider/model when the active LLM or embedding provider is removed - Ensured Langflow global variables and model values are refreshed after a provider removal (same as a provider update)

Issues: - #833 Summary Polished settings dialogs: form reset on open, autocomplete suppression, and label cleanup Form State & UX Fixes - Added useEffect to reset form state whenever a settings dialog is opened, preventing stale values from persisting across dialog sessions (Anthropic, OpenAI, Ollama, WatsonX) Password Field Improvements - Added autoComplete="new-password" to API key inputs in Anthropic, OpenAI, and WatsonX settings forms to suppress unwanted browser autofill suggestions Button Label Cleanup - Shortened the remove confirmation button label from "Confirm Remove" to "Remove" across all four provider dialogs (Anthropic, OpenAI, Ollama, WatsonX)

mfortman11

Nicely done!

Issues: - #833 Summary - Extracted duplicated dialog footer logic into a shared ModelProviderDialogFooter component across all four provider settings dialogs. Refactor: Shared Dialog Footer Component - Created model-provider-dialog-footer.tsx — a new reusable ModelProviderDialogFooter component that encapsulates both the remove-confirmation footer state and the standard save/cancel footer with optional "Remove" button - Defined a typed ModelProviderDialogFooterProps interface covering all props needed to drive both footer states (pending flags, configured/canRemove guards, tooltip text, and all action callbacks) Refactored: Provider Settings Dialogs - Replaced the duplicated inline DialogFooter JSX (including Tooltip/TooltipProvider wrappers) in anthropic-settings-dialog.tsx, ollama-settings-dialog.tsx, openai-settings-dialog.tsx, and watsonx-settings-dialog.tsx with a single <ModelProviderDialogFooter /> usage each - Removed per-dialog imports of DialogFooter, Tooltip, TooltipContent, TooltipProvider, and TooltipTrigger that were no longer needed after extraction

mpawlow · 2026-03-10T14:50:20Z

Status Update

Implemented additional feedback from @mfortman11

✅ Extracted duplicated dialog footer logic into a shared ModelProviderDialogFooter component across all four provider settings dialogs.
For full details, see: a578776

mpawlow self-assigned this Mar 3, 2026

github-actions Bot added frontend 🟨 Issues related to the UI/UX backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) enhancement 🔵 New feature or request labels Mar 3, 2026

mpawlow linked an issue Mar 3, 2026 that may be closed by this pull request

[Feat]: Settings UX should let you remove a model provider #833

Closed

2 tasks

mpawlow force-pushed the mp/feat/GH-833-ability-to-remove-ollama-model-provider branch from a67c97b to dc67467 Compare March 5, 2026 18:44

github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 5, 2026

mpawlow force-pushed the mp/feat/GH-833-ability-to-remove-ollama-model-provider branch from dc67467 to cdf9e8b Compare March 5, 2026 23:21

github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 5, 2026

mpawlow force-pushed the mp/feat/GH-833-ability-to-remove-ollama-model-provider branch from cdf9e8b to 0c6d72c Compare March 6, 2026 20:10

github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 6, 2026

mpawlow requested review from lucaseduoli and mfortman11 March 6, 2026 20:48

mpawlow commented Mar 6, 2026

View reviewed changes

mfortman11 requested changes Mar 6, 2026

View reviewed changes

mpawlow force-pushed the mp/feat/GH-833-ability-to-remove-ollama-model-provider branch from 0c6d72c to 57938ca Compare March 9, 2026 20:29

github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 9, 2026

github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 10, 2026

mpawlow added 2 commits March 10, 2026 05:48

mpawlow force-pushed the mp/feat/GH-833-ability-to-remove-ollama-model-provider branch from 2aeb6f6 to cc9e953 Compare March 10, 2026 12:48

github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 10, 2026

mfortman11 approved these changes Mar 10, 2026

View reviewed changes

Comment thread frontend/app/settings/_components/ollama-settings-dialog.tsx

github-actions Bot added the lgtm label Mar 10, 2026

github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 10, 2026

mpawlow merged commit c006d45 into main Mar 10, 2026
13 checks passed

github-actions Bot deleted the mp/feat/GH-833-ability-to-remove-ollama-model-provider branch March 10, 2026 15:10

mpawlow mentioned this pull request Mar 10, 2026

[Feat]: Settings UX should let you remove a model provider #833

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Settings UX should let you remove a model provider#1062

feat: Settings UX should let you remove a model provider#1062
mpawlow merged 3 commits into
mainfrom
mp/feat/GH-833-ability-to-remove-ollama-model-provider

mpawlow commented Mar 3, 2026 •

edited

Loading

Uh oh!

mpawlow Mar 6, 2026

Uh oh!

mfortman11 left a comment

Uh oh!

mpawlow commented Mar 6, 2026 •

edited

Loading

Uh oh!

mpawlow commented Mar 7, 2026

Uh oh!

aimurphy commented Mar 9, 2026

Uh oh!

mpawlow commented Mar 10, 2026 •

edited

Loading

Uh oh!

mfortman11 left a comment

Uh oh!

Uh oh!

mpawlow commented Mar 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mpawlow commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Summary

Frontend – Settings Dialogs

Frontend – Mutation Layer

Backend – Settings API

Form State & UX Fixes

Password Field Improvements

Button Label Cleanup

Refactor: Shared Dialog Footer Component

Refactored: Provider Settings Dialogs

Screenshots

Screencaps

Uh oh!

mpawlow Mar 6, 2026

Choose a reason for hiding this comment

(a) Implementation Note: Used standard animation found elsewhere in the OpenRAG application

Uh oh!

mfortman11 left a comment

Choose a reason for hiding this comment

Uh oh!

mpawlow commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mpawlow commented Mar 7, 2026

Uh oh!

aimurphy commented Mar 9, 2026

Uh oh!

mpawlow commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status Update

Uh oh!

mfortman11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mpawlow commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status Update

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mpawlow commented Mar 3, 2026 •

edited

Loading

mpawlow commented Mar 6, 2026 •

edited

Loading

mpawlow commented Mar 10, 2026 •

edited

Loading

mpawlow commented Mar 10, 2026 •

edited

Loading