feat: Add a dedicated failed-task ingestion status panel to give user info when ingestion failed#1047
Merged
Conversation
…ction UI. This opens the panel only for new ingestion failures and consolidates task timestamp/section rendering to keep the task UX consistent and easier to maintain. Made-with: Cursor
Wallgau
changed the title
Wallgau
changed the title
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
Resolve conflicts in knowledge page, task notification menu, and tailwind config while preserving failed-side-panel behavior. Made-with: Cursor
github-actions
Bot
added
enhancement
lucaseduoli
requested changes
Mar 5, 2026
lucaseduoli
left a comment
lucaseduoli
left a comment
Collaborator
There was a problem hiding this comment.
Good code-wise!
Some design reviews:
- The badges with the numbers are changing size and not staying as a circle, and they are a little bit too big
- When opening and closing a failed detail, the "Just now" text glitches and goes a little bit below.
- You can use the ShadCN Accordion to have a nicer animation
- We need to check if the Tasks menu should appear automatically when showing an error, since it's possible to see the error by clicking the Failed badge
- When opening the failed file, we shouldn't switch from "1 failed" to a badge with "Failed", we can leave it as just the previous one, for consistency
After some time, the tasks are not shown anymore, all tasks are on recent tasks instead of past tasks and I can't see the tasks failure:
github-actions
Bot
added
enhancement
Improve failed task UX by stabilizing timestamps, keeping count badges consistent, and using accordion-driven expansion so failures are easier to inspect without layout glitches. Made-with: Cursor
github-actions
Bot
added
enhancement
Use the new failure border token for the collapsed failed badge, keep the badge hidden while details are expanded, and remove debug-only logging and marker traces so the task panel behavior is consistent. Made-with: Cursor
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
Restore onboarding.spec.ts to require onboarding-content visibility, while keeping the task panel e2e stabilization changes. Made-with: Cursor
github-actions
Bot
added
enhancement
Make unified task panel tests deterministic by controlling mocked task state transitions, opening the task panel via a stable header test id, and expanding the recent tasks section before asserting failure log content. Made-with: Cursor
github-actions
Bot
added
enhancement
Prevent task panel tests from flaking when the panel is already open by only toggling the bell when needed, and only expanding Recent Tasks when the failure accordion is not already visible. Made-with: Cursor
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
Keep failed and completed task flows in one unified panel with recent/past bucketing, selected-task expansion, and INCOMPLETE status labeling for terminal failures. Made-with: Cursor
github-actions
Bot
added
enhancement
Ensure selected failed rows open the most recent matching task, preserve deterministic recent/past panel toggles, and harden E2E helpers for default-expanded failure details. Made-with: Cursor
github-actions
Bot
added
enhancement
github-actions
Bot
added
lgtm
enhancement
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #869
issue #851
The panel opens when a new ingestion failures occurs (also show past one) and consolidates task timestamp/section rendering to keep the task UX consistent and easier to maintain.
added some UI improvement to actually also show when task completed but failed: