fix: Extend update-uv-lock workflow to SDKs#1036
Merged
Merged
Conversation
Include sdks/python and sdks/mcp in the update-uv-lock workflow: add their pyproject.toml to the workflow triggers, run `uv sync` in each SDK directory, and include their uv.lock files in the change detection and commit steps. Update messages and commit text to reference the multiple uv.lock files so SDK lockfiles are kept in sync on version bumps.
edwinjosechittilappilly
requested review from
Copilot,
lucaseduoli and
mpawlow
github-actions
Bot
added
ci
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the existing update-uv-lock GitHub Actions workflow so SDK Python projects’ lockfiles are also regenerated and committed when their pyproject.toml changes, keeping dependency lockfiles aligned with version bumps.
Changes:
- Added
sdks/python/pyproject.tomlandsdks/mcp/pyproject.tomlto workflow path triggers. - Ran
uv syncinsdks/pythonandsdks/mcpto update theiruv.lockfiles. - Updated change detection and commit steps to include all three
uv.lockfiles.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
54
to
+60
| - name: Commit and push uv.lock | ||
| if: steps.changes.outputs.changed == 'true' | ||
| run: | | ||
| git config --local user.email "github-actions[bot]@users.noreply.github.com" | ||
| git config --local user.name "github-actions[bot]" | ||
| git add uv.lock | ||
| git commit -m "chore: update uv.lock after version bump [skip ci]" | ||
| git add uv.lock sdks/python/uv.lock sdks/mcp/uv.lock | ||
| git commit -m "chore: update uv.lock files after version bump [skip ci]" |
There was a problem hiding this comment.
The step name "Commit and push uv.lock" is now misleading since this workflow commits multiple lockfiles (root + SDKs). Rename the step (and optionally the job/workflow name) to reflect that it commits/pushes all uv.lock files, so the Actions logs remain accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include sdks/python and sdks/mcp in the update-uv-lock workflow: add their pyproject.toml to the workflow triggers, run
uv syncin each SDK directory, and include their uv.lock files in the change detection and commit steps. Update messages and commit text to reference the multiple uv.lock files so SDK lockfiles are kept in sync on version bumps.