fix: Resolve Component Render Error for chat input#1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug:
TextareaAutosizecallsonHeightChangefrom a React layout effect on every render. The original code didonHeightChange={(height) => setTextareaHeight(height)}, which triggered a re-render on every call. Worse,textareaHeightcontrolled the layout (flex-row vs flex-col), which changed the available width, which changed the textarea's height, which firedonHeightChangeagain — creating an infinite render loop.The fix: Removed
onHeightChangeand thetextareaHeightstate entirely. Instead, isMultiline is derived from two sources:This breaks the loop because handleChange only fires on actual user input, not on re-renders. Hysteresis prevents flickering at the boundary: expand when scrollHeight exceeds one line, but only collapse when text is under SAFE_SINGLE_LINE_CHARS characters.
Resolves #1012