Repository navigation
Use the official OllamaContainer in the Ollama starter ITs, and assert model pulls succeed - #212
Open
Lubaoshuai wants to merge 1 commit into
Open
Lubaoshuai wants to merge 1 commit into
Lubaoshuai wants to merge 1 commit into
Conversation
Author
|
Friendly ping — the "Java CI" workflow is sitting in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes langchain4j/langchain4j#2101
Change
Improves
AutoConfigITof the Ollama Spring Boot starter, as requested in the issue:GenericContainerwith the officialorg.testcontainers:ollamamodule (OllamaContainer), which declares the Ollama port itself and providesgetEndpoint().ollama pullfor both models (phi,all-minilm), so a missing or renamed model now fails fast with a clear message instead of surfacing as confusing downstream test failures.org.testcontainers:ollamaas a test dependency (version managed by the Spring Boot BOM).OLLAMA_BASE_URLescape hatch for pointing the ITs at an external Ollama instance is preserved.Note: the Ollama ITs are excluded from the PR build via
-DskipOllamaITsand run in the nightly workflow; Docker is not available in my local environment, so they were verified by compile + review and will be exercised by the nightly run.General checklist