Repository navigation
fix: accept github line anchors on markdown link targets - #986
Merged
Colin Francis (colifran) merged 3 commits intoOct 6, 2026
Merged
Conversation
The link validator treated #L10 or #L10-L20 on a .md target as a heading anchor and stamped the link as broken. Skip line anchors there; real heading anchors are still checked. Fixes langchain-ai#983
🦋 Changeset detectedLatest commit: a3aaffe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Colin Francis (colifran)
changed the title
Colin Francis (colifran)
approved these changes
Oct 6, 2026
Colin Francis (colifran)
left a comment
Colin Francis (colifran)
left a comment
Collaborator
There was a problem hiding this comment.
thanks Younes Beriane (@drakeo338)!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #983.
Covers the item about GitHub line anchors (
#L10,#L10-L20) on Markdown link targets being reported as broken.The wiki link validator treated any
#fragmenton a.mdtarget as a heading anchor, so a link likefile.md#L10-L20was stamped broken because no such heading exists. It now skips GitHub line anchors on Markdown targets, while real heading anchors are still validated. Added a test covering both cases and a changeset.