align SupabaseVectorStore ID handling with JS lib #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR
from_textsandadd_textsmethods)When IDs aren't provided, the database is now responsible for generating them instead of the library forcing UUID strings.
Why need this change
The current Python implementation has several limitations compared to the TypeScript version especially when I use
SupabaseVectorStore.from_documents:from_textsmethod (which is called byfrom_documentsmethod), preventing use ofAUTO_INCREMENT,SERIAL, or custom ID strategiesfrom_texts()methodWhat's the solution
add_texts()andfrom_texts()methodsadd_vectors()and_add_vectors()methodsuuidimportWhen IDs are provided:
When IDs are NOT provided: