Conversation
reynoldsalec
force-pushed
the
3-pgsql
branch
3 times, most recently
from
b5df70b to
87a5fb7
Compare
reynoldsalec
force-pushed
the
3-pgsql
branch
2 times, most recently
from
0296082 to
110e338
Compare
|
I'm getting intermittent failures on the Postgres tests, typically on trying to run Not able to replicate locally and the service it fails on varies, so it seems truly intermittent. Maybe I need to introduce a wait? LMK if you have ideas on that @pirog |
|
@reynoldsalec yah im guessing you are right on the wait. i think what id do for now is just introduce a sufficiently large then spin up an issue that flags this concern eg "postgres isnt always ready after lando starts" or something. im guessing what we will want to do there is introduce a healthcheck for postgres to ensure it is ready to go before lando reports start as complete. in the issue we should also include a task to remove the sleep from the tests. |
|
Healthcheck implementation on Lando's postgres service: https://github.com/lando/cli/blob/main/plugins/lando-services/services/postgres/builder.js#L26 |
|
Looks like adding in a health check to the platform-postgresql service worked; postgres tests are passing. Merging. |
2 participants
Two questions:
lando ssh -s postgresql -c "id" | grep appI get...uid=501(postgres) gid=20(dialout) groups=20(dialout),102(ssl-cert),103(postgres)...which of course fails. Am I not understanding the goal of that test?
lando postgresql main -c "\dt"I receive "No relations found." Is that ok? Was assuming based on the mysql tests that we're just checking to make sure the command runs without an error, not that data exists (which it shouldn't).