Skip to content

Mariadb client compatibility#213

Merged
AaronFeledy merged 1 commit into
db-client-configfrom
cursor/mariadb-client-compatibility-e14d
Feb 18, 2026
Merged

Mariadb client compatibility#213
AaronFeledy merged 1 commit into
db-client-configfrom
cursor/mariadb-client-compatibility-e14d

Conversation

@cursor

@cursor cursor Bot commented Feb 18, 2026

Copy link
Copy Markdown

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.


This PR addresses two bugs:

  1. MariaDB wrapper script generates wrong command names: The mariadb-compat-install.sh script was incorrectly generating command names like mariadbdump instead of mariadb-dump, preventing compatibility wrappers for tools like mysqldump from being created. The fix adds a hyphen to correctly form the MariaDB command names.
  2. Auto-detection returns wrong client in multi-database test: In the db-client test example, the php-mysql84 service with db_client: auto was incorrectly detecting a mariadb service in the same Landofile due to global auto-detection logic. The fix explicitly sets db_client: mysql:8.4 for the php-mysql84 service in the test to ensure it uses the intended client.

Note

Low Risk
Small, localized changes to an example config and a wrapper-name generation script; low risk aside from potential missed wrapper creation if command naming expectations differ across distros.

Overview
Fixes the MariaDB compatibility install script so wrapper commands for mysqldump, mysqladmin, etc. map to the correct MariaDB binaries (e.g., mariadb-dump instead of mariadbdump) by inserting the required hyphen when building command names.

Updates the examples/db-client Landofile to explicitly set db_client: mysql:8.4 for the php-mysql84 service to avoid incorrect client auto-detection in a multi-database setup.

Written by Cursor Bugbot for commit a328c40. This will update automatically on new commits. Configure here.

- Fix mariadb-compat-install.sh to use hyphens in command names (mariadb-dump instead of mariadbdump)
- Add explicit db_client: mysql:8.4 to php-mysql84 test service to avoid auto-detection issues in multi-database environments
@cursor

cursor Bot commented Feb 18, 2026

Copy link
Copy Markdown
Author

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@AaronFeledy AaronFeledy marked this pull request as ready for review February 18, 2026 03:23
@AaronFeledy AaronFeledy merged commit f5ab23c into db-client-config Feb 18, 2026
6 of 38 checks passed
@AaronFeledy AaronFeledy deleted the cursor/mariadb-client-compatibility-e14d branch February 18, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants