Mariadb client compatibility#213
Merged
AaronFeledy merged 1 commit intoFeb 18, 2026
Merged
Conversation
- Fix mariadb-compat-install.sh to use hyphens in command names (mariadb-dump instead of mariadbdump) - Add explicit db_client: mysql:8.4 to php-mysql84 test service to avoid auto-detection issues in multi-database environments
Author
|
Cursor Agent can help with this pull request. Just |
AaronFeledy
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.
This PR addresses two bugs:
mariadb-compat-install.shscript was incorrectly generating command names likemariadbdumpinstead ofmariadb-dump, preventing compatibility wrappers for tools likemysqldumpfrom being created. The fix adds a hyphen to correctly form the MariaDB command names.db-clienttest example, thephp-mysql84service withdb_client: autowas incorrectly detecting amariadbservice in the same Landofile due to global auto-detection logic. The fix explicitly setsdb_client: mysql:8.4for thephp-mysql84service in the test to ensure it uses the intended client.Note
Low Risk
Small, localized changes to an example config and a wrapper-name generation script; low risk aside from potential missed wrapper creation if command naming expectations differ across distros.
Overview
Fixes the MariaDB compatibility install script so wrapper commands for
mysqldump,mysqladmin, etc. map to the correct MariaDB binaries (e.g.,mariadb-dumpinstead ofmariadbdump) by inserting the required hyphen when building command names.Updates the
examples/db-clientLandofile to explicitly setdb_client: mysql:8.4for thephp-mysql84service to avoid incorrect client auto-detection in a multi-database setup.Written by Cursor Bugbot for commit a328c40. This will update automatically on new commits. Configure here.