Skip to content

Bugfix to address upstream changes to sqlcmd path and options causing healthcheck to fail#37

Merged
reynoldsalec merged 6 commits intolando:mainfrom
sdunham:bugfix/sqlcmd-fixes
Sep 18, 2024
Merged

Bugfix to address upstream changes to sqlcmd path and options causing healthcheck to fail#37
reynoldsalec merged 6 commits intolando:mainfrom
sdunham:bugfix/sqlcmd-fixes

Conversation

@sdunham
Copy link
Copy Markdown
Contributor

@sdunham sdunham commented Aug 11, 2024 •
edited
Loading

This PR fixes #36

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 11, 2024 •
edited
Loading

👷 Deploy request for lando-mssql pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 58caeb1

AaronFeledy
AaronFeledy previously approved these changes Aug 11, 2024
View reviewed changes
@AaronFeledy AaronFeledy mentioned this pull request Aug 11, 2024
Closed
sdunham
sdunham commented Aug 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@sdunham sdunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will only let me comment, not approve. Looks good to me, but I did flag a small documentation issue

@sdunham
Copy link
Copy Markdown
Contributor Author

sdunham commented Aug 21, 2024

@AaronFeledy @reynoldsalec Just wanted to check if there are any updates here, or anything I can do to help move this forward.

@reynoldsalec reynoldsalec merged commit 5e4a86f into lando:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AaronFeledy AaronFeledy AaronFeledy left review comments

@reynoldsalec reynoldsalec Awaiting requested review from reynoldsalec

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recent MSSQL changes cause healthcheck to fail

3 participants

@sdunham @AaronFeledy @reynoldsalec