Skip to content

Conversation

@AaronFeledy
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented May 18, 2025

Deploy Preview for lando-core ready!

Name Link
🔨 Latest commit 63f3a36
🔍 Latest deploy log https://app.netlify.com/projects/lando-core/deploys/68c03532e083910008a769ca
😎 Deploy Preview https://deploy-preview-362--lando-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🟢 up 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@AaronFeledy
Copy link
Member Author

@pirog I can't replicate these Leia test failures locally. Any ideas?

@AaronFeledy
Copy link
Member Author

ssl: true seems to be what breaks things in GHA

@pirog
Copy link
Member

pirog commented Sep 9, 2025

@AaronFeledy i investigated this and the issue is a bug in core.

tl;dr is that the scripts/install-plugins.sh passes in dependencies to be ignored and core assumes that dependencies are at least defined in package.json which in mailpit they are not.

I will fix this in core and then the tests should pass here.

@pirog pirog self-assigned this Sep 9, 2025
@pirog pirog merged commit b2dbd2c into main Sep 9, 2025
73 checks passed
@pirog pirog deleted the mailpit branch September 9, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants