refactor: pull node binaries into separate packages#88
Merged
Conversation
wjones127
force-pushed
the
wjones127/release-ci
branch
16 times, most recently
from
May 25, 2023 06:03
d85cb06 to
1d00a1d
Compare
wjones127
force-pushed
the
wjones127/release-ci
branch
from
May 25, 2023 16:23
6a5358d to
f9db5fe
Compare
wjones127
force-pushed
the
wjones127/release-ci
branch
3 times, most recently
from
May 25, 2023 17:59
700d4d3 to
9990ad0
Compare
wjones127
force-pushed
the
wjones127/release-ci
branch
4 times, most recently
from
May 25, 2023 23:58
09baa19 to
968b024
Compare
wjones127
force-pushed
the
wjones127/release-ci
branch
from
May 26, 2023 23:31
968b024 to
d236303
Compare
wjones127
changed the title
wjones127
marked this pull request as ready for review
May 27, 2023 00:00
gsilvestrin
reviewed
May 30, 2023
| "author": "Lance Devs", | ||
| "license": "Apache-2.0", | ||
| "devDependencies": { | ||
| "@neon-rs/cli": "^0.0.74", |
Contributor
There was a problem hiding this comment.
My concern here is mostly how experimental neon-rs is since it is not a project maintained by the neon project itself. Can we migrate away from it if needed?
Contributor
Author
There was a problem hiding this comment.
I agree. I hope neon-bindings gets an official tool for this soon. neon-rs is written by one of the core maintainers of neon-bindings, so I'm hopeful it will become official eventually. If that doesn't happen, we will have to decide whether we want to fork neon-rs and maintain it ourselves, or switch to napi-rs which does provide these utilities.
gsilvestrin
approved these changes
May 30, 2023
gsilvestrin
left a comment
gsilvestrin
left a comment
Contributor
There was a problem hiding this comment.
LGTM, minor comments
gsilvestrin
pushed a commit
that referenced
this pull request
Jun 1, 2023
This reverts commit e50b642.
gsilvestrin
added a commit
that referenced
this pull request
Jun 1, 2023
jaichopra
pushed a commit
that referenced
this pull request
Jun 2, 2023
Changes: * Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Brings Rust and Node versions in alignment at 0.1.2. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates.
jaichopra
pushed a commit
that referenced
this pull request
Jun 2, 2023
jaichopra
pushed a commit
that referenced
this pull request
Jun 2, 2023
Changes: * Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Brings Rust and Node versions in alignment at 0.1.2. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates.
jaichopra
pushed a commit
that referenced
this pull request
Jun 2, 2023
jaichopra
pushed a commit
that referenced
this pull request
Jun 2, 2023
Changes: * Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Brings Rust and Node versions in alignment at 0.1.2. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates.
jaichopra
pushed a commit
that referenced
this pull request
Jun 2, 2023
gsilvestrin
pushed a commit
that referenced
this pull request
Jun 15, 2023
Changes: * Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Brings Rust and Node versions in alignment at 0.1.2. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates.
gsilvestrin
pushed a commit
that referenced
this pull request
Jun 15, 2023
Changes: * Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Brings Rust and Node versions in alignment at 0.1.2. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates.
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
Changes: * Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Brings Rust and Node versions in alignment at 0.1.2. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates.
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
…)" (lancedb#122) This reverts commit d059639.
alexkohler
pushed a commit
to alexkohler/lancedb
that referenced
this pull request
Apr 20, 2024
This keeps the format a little simpler and gives us room to figure out where to put it (along with index perhaps?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
npm install vectordb, the correct optional dependency is automatically downloaded by npm.