Repository navigation
test(nodejs): cover camelCase column names across table surfaces - #4586
Merged
Merged
Conversation
Extends the column name options tests to pin camelCase handling on the surfaces lancedb#3211 asked for: unquoted where filters, update, delete, mergeInsert join keys, addColumns SQL expressions, and createIndex.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
github-actions
Bot
added
the
chore
![lancedb-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4497274?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lancedb-gatekeeper
Bot
added
the
K-approved
…r4586-raw-sql-camelcase-20261101
lancedb-gatekeeper
Bot
added
K-approved
lancedb-gatekeeper
Bot
added
the
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #3211.
The core
col()camelCase integration coverage requested by #3211 is already onmainfrom #4493. This PR adds the adjacent raw-SQL table-surface regressions that were previously uncovered:where("camelCase = 1")updateanddeletewith unquoted camelCase predicatesmergeInsertwith a camelCase join key, including matched-update and not-matched-insert inputaddColumnsvalueSqlreferencing a camelCase columncreateIndexon a camelCase columnThese are characterization tests for the existing local-backend behavior. They do not add
col()coverage or require a live remote service.