Skip to content

fix(node): accept exist_ok in createTable - #4432

Merged
Xuanwo merged 2 commits into
lancedb:mainfrom
canyang25:cursor/ts-create-table-exist-ok-mode-3c76
Oct 22, 2026
Merged

Xuanwo merged 2 commits into
lancedb:mainfrom
canyang25:cursor/ts-create-table-exist-ok-mode-3c76

Conversation

@canyang25

Copy link
Copy Markdown
Contributor

TypeScript CreateTableOptions.mode omitted exist_ok even though createTable already forwards that mode to the native client.

closes: #2900

TypeScript CreateTableOptions.mode omitted exist_ok even though
createTable already forwards that mode to the native client.
Regenerate the TypeScript API docs so mode includes exist_ok.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

ACTION NEEDED

Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@lancedb-gatekeeper lancedb-gatekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Gate recommendation: approve.

This aligns the TypeScript createTable options with the native API’s existing exist_ok mode. The regression covers creating a missing table and reopening an existing table without replacing its rows.

@canyang25 canyang25 changed the title Fix(node): accept exist_ok in createTable mode fix(node): accept exist_ok in createTable Oct 5, 2026
@github-actions github-actions Bot added the bug Something isn't working label Oct 5, 2026
@lancedb-gatekeeper lancedb-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Oct 5, 2026
@Xuanwo
Xuanwo merged commit cc9f01a into lancedb:main Oct 22, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(python): create_table() incompatibilities between LanceDBConnection and RemoteDBConnection

2 participants