Skip to content

ci: pin ad-m/github-push-action to a full commit SHA in the release job#3677

Merged
wjones127 merged 1 commit into
lancedb:mainfrom
kobihikri:ci-pin-github-push-action
Jul 16, 2026
Merged

ci: pin ad-m/github-push-action to a full commit SHA in the release job#3677
wjones127 merged 1 commit into
lancedb:mainfrom
kobihikri:ci-pin-github-push-action

Conversation

@kobihikri

Copy link
Copy Markdown
Contributor

Hi, and thank you for LanceDB.

Small CI supply-chain hardening. In make-release-commit.yml, the release job checks out with LANCEDB_RELEASE_TOKEN (a push-capable PAT) and its final step pushes the version tag using a third-party action pinned to a mutable branch:

- name: Push new version tag
  uses: ad-m/github-push-action@master
  with:
    github_token: ${{ secrets.LANCEDB_RELEASE_TOKEN }}

@master can move after review; whatever it points at then runs with that release token in scope. This PR pins it to the commit behind the current release (v1.3.0881a6320…), keeping the version visible as a comment. Behavior today is unchanged.

For transparency: I used AI assistance to spot and draft this; I verified the workflow and resolved the SHA myself.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the ci label Jul 16, 2026
@wjones127
wjones127 merged commit dfce767 into lancedb:main Jul 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants