Skip to content

fix(node): sanitize Map fields across Arrow versions#3650

Merged
wjones127 merged 1 commit into
lancedb:mainfrom
u70b3:fix/node-map-schema-sanitization
Jul 21, 2026
Merged

fix(node): sanitize Map fields across Arrow versions#3650
wjones127 merged 1 commit into
lancedb:mainfrom
u70b3:fix/node-map-schema-sanitization

Conversation

@u70b3

@u70b3 u70b3 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • reconstruct foreign Arrow Map schemas from their single sanitized entries field
  • reject malformed Map types with anything other than one child
  • preserve the complete Map schema and keysSorted value through empty-table creation and IPC round trips across Arrow 15–18

Testing

  • ./node_modules/.bin/jest --runInBand __test__/arrow.test.ts __test__/sanitize.test.ts
  • pnpm lint
  • pnpm build
  • pnpm run docs

Fixes #2337

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the bug Something isn't working label Jul 13, 2026

@wjones127 wjones127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

@u70b3
u70b3 force-pushed the fix/node-map-schema-sanitization branch from aba79f9 to 167dff3 Compare July 14, 2026 05:03
@wjones127
wjones127 merged commit ac99e4d into lancedb:main Jul 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(node): Looks like Map fields are not supported on empty LanceDB table creation

2 participants