fix(python): route local sync namespace operations through rust#3606
Merged
wjones127 merged 1 commit intoJul 16, 2026
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
wjones127
self-requested a review
July 6, 2026 23:31
wjones127
approved these changes
Jul 13, 2026
| if namespace_client is None: | ||
| conn_uri = getattr(self._conn, "uri", "") | ||
| if get_uri_scheme(conn_uri) == "namespace": | ||
| if get_uri_scheme(conn_uri) == "namespace" or self._namespace_path: |
Contributor
There was a problem hiding this comment.
nitpick: it would be worth a comment why there's two possibilities here, and which they come from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes local sync child-namespace operations through the Rust-backed connection instead of the Python namespace-client fallback.
Also keeps lazy namespace-client construction for table-to-Lance conversion and preserves public namespace error mappings.
Validated locally with ruff format/check and targeted namespace pytest.