fix: support LargeList label list indexes#3529
Merged
Merged
Conversation
github-actions
Bot
added
bug
Xuanwo
marked this pull request as ready for review
June 10, 2026 08:28
BubbleCal
reviewed
Jun 10, 2026
| @@ -3914,6 +3922,22 @@ mod tests { | |||
| async fn test_create_index_nested_field_paths() { | |||
Contributor
There was a problem hiding this comment.
This only verifies the outbound create_index request. The regression also affects the remote response path (list_indices / index_stats), so we should add a mocked response assertion for these new nested field cases to catch leaf-only name regressions.
BubbleCal
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends nested-field regression coverage across Rust local/remote, Python sync/async, and Node so canonical escaped paths stay consistent across scalar, vector, and FTS index lifecycle behavior.
It also aligns LanceDB's LabelList type gate with Lance by accepting
LargeList<primitive>columns while keepingList<Struct<...>>unsupported until Lance defines stable membership semantics for struct labels.Part of #3406.