fix(python): raise clear TypeError for bare List/Tuple in pydantic schema conversion#3511
Merged
Merged
Conversation
Contributor
Author
|
Friendly ping! Let me know if any changes are needed. |
Contributor
Author
|
Hi, friendly ping, please let me know if any changes are needed. |
wjones127
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3502
Problem
A bare, unparameterised
typing.List/typing.Tuplefield crashesto_arrow_schemawith an opaqueAttributeError: __args__:In
_py_type_to_arrow_type, the branchelif getattr(py_type, "__origin__", None) in (list, tuple)is taken for a bare generic (its__origin__islist / tuple), but the next line readspy_type.__args__[0], and a bare generic has no__args__. Other unsupported types (e.g.Dict[str, int]) correctly raise a clearTypeError, so this case is inconsistent.Fix
Guard the element-type lookup with
getattr(py_type, "__args__", None)and raise a clearTypeErrorwhen it is missing, matching the existing behavior for other unsupported types. Bare builtin list / tuple are unaffected (their__origin__isNone, so they already fall through to the existingTypeError).Testing
test_bare_generic_raises_type_errorcovering bothListandTuple.