refactor!: drop unused loss field from IndexStatistics#3496
Merged
Conversation
The loss field was local-only; LanceDB Cloud never returned it and RemoteTable always set it to None. Remove it from IndexStatistics and the internal IndexMetadata, along with the summing logic in NativeTable::index_stats. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
github-actions
Bot
added
Python
wjones127
marked this pull request as ready for review
June 3, 2026 18:54
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
westonpace
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: direct Rust users lose the
IndexStatistics::lossfield. Python and Node.js consumers are unaffected in practice for remote tables (the value was alwaysNone/absent), but the attribute is gone for local tables too.IndexStatistics::losswas local-only — LanceDB Cloud never returned it, soRemoteTable::index_statsalways setloss: None. It's vestigial; this removes it.lossfromIndexStatisticsand the internalIndexMetadatainrust/lancedb/src/index.rs, plus the summing logic inNativeTable::index_stats.lossfrom the Python and Node.js bindings (and their tests/docs).Fixes #3493
🤖 Generated with Claude Code