fix(node): remove redundant postbuild:release script to fix build failure#3285
Merged
Merged
Conversation
…lure Signed-off-by: qingfeng-occ <[email protected]>
Contributor
Author
|
Hi @wjones127 @jackye1995 @Xuanwo , |
westonpace
approved these changes
May 4, 2026
westonpace
left a comment
westonpace
left a comment
Contributor
There was a problem hiding this comment.
Thanks for cleaning this up. I guess it raises a larger question of why we aren't using this in our publish workflows. Those use...
npx napi build --platform --release \
--features ${{ matrix.settings.features }} \
--target ${{ matrix.settings.target }} \
--dts ../lancedb/native.d.ts \
--js ../lancedb/native.js \
--strip \
$EXTRA_ARGS \
--output-dir dist/
So we've already deviated a little on --strip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build:releasecommand already outputs the*.nodefiles directly to thedist/directory via the--output-dir distflag.Therefore, the
postbuild:releasescript, which attempts to copy*.nodefiles from thelancedb/source directory, fails with a "no such file or directory" error because the source files do not exist there.This commit removes the redundant
postbuild:releasescript to resolve the build failure.fix #3284